tools,doc: move more MDN links to types #58930
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
doc
legendecas
approved these changes
Jul 2, 2025
aduh95
added
the
author ready
ovflowd
approved these changes
Jul 3, 2025
There was a problem hiding this comment.
cc @avivkeller to update counterpart on api-docs-tooling.
LGTM!
aduh95
added
the
commit-queue
|
Noted! I'll update the counterpart by the end of the day |
avivkeller
added a commit
to nodejs/api-docs-tooling
that referenced
this pull request
Jul 3, 2025
lpinca
approved these changes
Jul 3, 2025
atlowChemi
approved these changes
Jul 4, 2025
ovflowd
approved these changes
Jul 4, 2025
nodejs-github-bot
removed
the
commit-queue
|
Landed in 1d08014 |
ovflowd
pushed a commit
to nodejs/api-docs-tooling
that referenced
this pull request
Jul 5, 2025
* chore(types): mirror nodejs/node#58930 * fixup!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It feels inconsistent to treat differently JS built-ins and web classes. Using types also lowers the maintenance burden as we don't need to manage it in the markdown file.