[ADD] estate: create real estate module #783

clom-odoo · 2025-05-19T13:09:52Z

Creation of a module for real estate.
There should be more description however it's work in progress

robodoo · 2025-05-19T13:09:54Z

…p_by

…cs settings

…es and set properties as sold/cancelled

…heritance and add a page in User to see Properties linked to salesperson

…ideline and clear some typos This commit will refactor estate_property in estate.property as recommended. Some file name especially those who deals with inhertiance are changed accoridng to the guideline.

ushyme

Good work overall. One general remark: There are inconsistencies with the use of single/double quotes. We generally use different quote signs to distinguishes between technical strings (single quotes) and user-facing strings (double quotes).

ushyme · 2025-05-22T20:34:25Z

estate/models/estate_properties.py

+    date_availability = fields.Date(
+        "Date availability",
+        copy=False,
+        default=fields.Date.today() + relativedelta(months=3))


Suggested change

default=fields.Date.today() + relativedelta(months=3))

default=lambda: fields.Date.today() + relativedelta(months=3))

As it is now, fields.Date.today() + relativedelta(months=3) is evaluated once when the class is loaded, not each time a record is created. Use a function returning the value so it's evaluated on each record creation.

ushyme · 2025-05-26T09:37:24Z

estate/security/ir.model.access.csv

+estate.access_estate_property,access_estate_property,estate.model_estate_property,base.group_user,1,1,1,1
+estate.access_estate_property_type,access_estate_property_type,estate.model_estate_property_type,base.group_user,1,1,1,1
+estate.access_estate_property_tag,access_estate_property_tag,estate.model_estate_property_tag,base.group_user,1,1,1,1
+estate.access_estate_property_offer,access_estate_property_offer,estate.model_estate_property_offer,base.group_user,1,1,1,1


Suggested change

estate.access_estate_property_offer,access_estate_property_offer,estate.model_estate_property_offer,base.group_user,1,1,1,1

estate.access_estate_property_offer,access_estate_property_offer,estate.model_estate_property_offer,base.group_user,1,1,1,1

Remember to leave an empty line at the end of files. While it seems trivial, it ensures compatibility with many tools and version control systems.

ushyme · 2025-05-26T09:37:44Z

estate/views/estate_menus.xml

+            <menuitem id="estate_tag_menu_action" action="estate_property_tag_action"/>
+        </menuitem>
+    </menuitem>
+</odoo>


Suggested change

</odoo>

</odoo>

ushyme · 2025-05-26T13:08:48Z

estate/views/res_user.xml

+        </xpath>
+    </field>
+</record>
+</odoo>


Suggested change

</odoo>

</odoo>

ushyme · 2025-05-26T13:14:11Z

estate/models/estate_property.py

+    date_availability = fields.Date(
+        "Date availability",
+        copy=False,
+        default=fields.Date.today() + relativedelta(months=3))


Suggested change

date_availability = fields.Date(

"Date availability",

copy=False,

default=fields.Date.today() + relativedelta(months=3))

date_availability = fields.Date(

"Date availability",

copy=False,

default=lambda: fields.Date.today() + relativedelta(months=3))

As it is now, fields.Date.today() + relativedelta(months=3) is evaluated once when the class is loaded, not each time a record is created. Use a function returning the value so it’s evaluated on each record creation.

ushyme · 2025-05-26T14:17:24Z

estate/views/estate_property_tag_views.xml

+        <field name="name">estate.property.tag.form</field>
+        <field name="model">estate.property.tag</field>
+        <field name="arch" type="xml">
+            <form string="Property">


Suggested change

<form string="Property">

<form string="Property Tag">

ushyme · 2025-05-26T14:23:07Z

estate/views/estate_property_offer_views.xml

+        <field name="name">estate.property.offer.form</field>
+        <field name="model">estate.property.offer</field>
+        <field name="arch" type="xml">
+            <form string="Property">


Suggested change

<form string="Property">

<form string="Property Offer">

ushyme · 2025-05-26T14:27:42Z

estate_account/models/estate_property.py

+        res = super().action_sold()
+        self.env['account.move'].create({
+            "move_type": 'out_invoice',
+            "partner_id": self.buyer.id,


What if the self.buyer doesn't exist ?

As buyer is a many2one field it gets a blank template by default. Therefore there is a field buyer.id with the value False which is interpreted as no buyer.

So when there is no buyer, this will create an invoice with no Customer

ushyme · 2025-05-26T14:38:04Z

estate/views/estate_property_type_views.xml

+                        <!-- 
+                        <div class="o_field_widget o_stat_info">
+                            <span class="o_stat_value d-flex gap-1">
+                                <field name="offer_count" widget="statinfo" nolabel="1" class="oe_inline"/>
+                                <field name="name" class="oe_inline"/>
+                            </span>
+                        </div>
+                        -->


Suggested change



In general, we try to use comments to add context to the code. This doesn't seem to add much.

I forgot to uncomment it after debugging

ushyme · 2025-05-26T14:38:40Z

estate/views/estate_property_views.xml

+                <field string="Bedrooms" name="bedrooms"/>
+                <field string="Living Area (sqm)" name="living_area" filter_domain="[('living_area', '&gt;', self)]"/>
+                <field string="Facades" name="facades"/>
+                <filter string="Available" name="state_availability_filter" domain="['|',('state','=', 'new'), ('state','=','offer received')]"/>


Domains have a in operator

…the review Add a lambda fonction to the default field computing a date based on fields.Date.today method. Add a line at the end of file for files where it was missing. Adapted the create method of the EstatePropertyOffer to match the api.model_create_multi decorator. Add a call to the self.env._ method at each UserError callto export them for translation. Updated class name according to the guideline to match their model name in CamelCase format. Updated 'offer received' and 'offer accepted' to snake_case formatting. Updated misleading _sql_constraints name and error from estate_property_type. Switch to default return value instead of a workaround for max method in estate/models/estate_property.py . Updated action_confirm to: 1) right algorithm 2) better readability using write and filtered method Corrected some string field in xml. Uncommented the core of a stat_button that was only displaying 'test'.

[ADD] estate: create real estate module

b9f73ab

clom-odoo force-pushed the 18.0-tutorial-clom branch from 4b7b110 to 821971f Compare May 19, 2025 14:59

[IMP] estate: add a model for estate properties

535d597

clom-odoo force-pushed the 18.0-tutorial-clom branch from 821971f to 3e0c64e Compare May 19, 2025 15:27

[IMP] estate: add some basic security

6181942

clom-odoo force-pushed the 18.0-tutorial-clom branch from 3e0c64e to 6181942 Compare May 20, 2025 08:41

clom-odoo added 2 commits May 20, 2025 15:40

[IMP] estate: added some menus and updated fields and defaults value

029d96f

[IMP] estate: customized the search bar with fields, filters and grou…

8e8fc10

…p_by

clom-odoo force-pushed the 18.0-tutorial-clom branch 2 times, most recently from b357377 to 88c49fd Compare May 21, 2025 08:06

[IMP] estate: add relational fields about property Type, Tags and Offers

f87c7c8

clom-odoo force-pushed the 18.0-tutorial-clom branch 3 times, most recently from f3aee3d to be3fe3d Compare May 21, 2025 13:24

clom-odoo added 2 commits May 21, 2025 16:53

[IMP] estate: update some fields to be computed and add onchange basi…

46f9577

…cs settings

[IMP] estate: add some actions to cancel or accept offer for properti…

1775268

…es and set properties as sold/cancelled

clom-odoo force-pushed the 18.0-tutorial-clom branch from be3fe3d to 5d8670f Compare May 21, 2025 14:55

[IMP] estate: add some sql and python constraints

3d66c40

clom-odoo force-pushed the 18.0-tutorial-clom branch from 5d8670f to 3d66c40 Compare May 21, 2025 15:18

clom-odoo added 2 commits May 22, 2025 16:03

[IMP] estate: add some color, ordering and stats buttons

2d1fc29

[IMP] estate: add some protection on create/delete operation using in…

4bddac7

…heritance and add a page in User to see Properties linked to salesperson

clom-odoo force-pushed the 18.0-tutorial-clom branch from ea014ea to 4bddac7 Compare May 23, 2025 07:15

[ADD] estate_account: module to create invoice from properties when sold

4bc26bc

clom-odoo force-pushed the 18.0-tutorial-clom branch from 77e21d7 to 4bc26bc Compare May 23, 2025 12:39

clom-odoo added 2 commits May 23, 2025 14:41

[IMP] estate: add a not draggable Kanban view for estate_property

05db246

[REF] estate, estate_account: change names according to the coding gu…

fb559d6

…ideline and clear some typos This commit will refactor estate_property in estate.property as recommended. Some file name especially those who deals with inhertiance are changed accoridng to the guideline.

ushyme suggested changes May 26, 2025

View reviewed changes

clom-odoo force-pushed the 18.0-tutorial-clom branch from 6a68bec to 7d4bb56 Compare May 27, 2025 13:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[ADD] estate: create real estate module #783

[ADD] estate: create real estate module #783

Uh oh!

clom-odoo commented May 19, 2025

Uh oh!

robodoo commented May 19, 2025

Uh oh!

ushyme left a comment

Uh oh!

ushyme May 22, 2025

Uh oh!

ushyme May 26, 2025

Uh oh!

ushyme May 26, 2025

Uh oh!

ushyme May 26, 2025

Uh oh!

ushyme May 26, 2025

Uh oh!

ushyme May 26, 2025

Uh oh!

ushyme May 26, 2025

Uh oh!

ushyme May 26, 2025

Uh oh!

clom-odoo May 27, 2025

Uh oh!

ushyme May 26, 2025

Uh oh!

clom-odoo May 27, 2025

Uh oh!

ushyme May 26, 2025

Uh oh!

Uh oh!

	default=fields.Date.today() + relativedelta(months=3))
	default=lambda: fields.Date.today() + relativedelta(months=3))

	estate.access_estate_property_offer,access_estate_property_offer,estate.model_estate_property_offer,base.group_user,1,1,1,1
	estate.access_estate_property_offer,access_estate_property_offer,estate.model_estate_property_offer,base.group_user,1,1,1,1

[ADD] estate: create real estate module #783

Are you sure you want to change the base?

[ADD] estate: create real estate module #783

Uh oh!

Conversation

clom-odoo commented May 19, 2025

Uh oh!

robodoo commented May 19, 2025

Uh oh!

ushyme left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!