Skip to content
This repository was archived by the owner on Oct 13, 2021. It is now read-only.

[Opset 10] Updating ThresholdedRelu and onnxconverter-common package #96

Merged
merged 27 commits into from
Jun 10, 2019

Conversation

vinitra-zz
Copy link

@vinitra-zz vinitra-zz commented May 28, 2019

  • Updates for ThresholdedRelu for graduation from experimental to full op
  • MaxPool and AveragePool have the ceil_mode attribute in Opset 10 -- default is 0, with floor in the calculation for spatial dimensions Covered in changes in PR Add unit tests for upsample and pool #99
  • Adding unit test coverage for ThresholdedRelu
  • Updating onnxconverter_common version to 1.5.0

@vinitra-zz vinitra-zz requested review from wenbingl and jiafatom May 28, 2019 18:59
Copy link
Collaborator

@jiafatom jiafatom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have some unit tests to cover these change?

@vinitra-zz vinitra-zz changed the title [Opset 10] Updating MaxPool, AveragePool, and ThresholdedRelu [Opset 10] Updating ThresholdedRelu Jun 3, 2019
@jiafatom
Copy link
Collaborator

Let's add tests for previous opsets to ensure test coverage. Thanks.

@jiafatom jiafatom self-requested a review June 10, 2019 21:40
@vinitra-zz vinitra-zz changed the title [Opset 10] Updating ThresholdedRelu [Opset 10] Updating ThresholdedRelu and onnxconverter-common package Jun 10, 2019
@vinitra-zz vinitra-zz merged commit 4abc0c9 into onnx:master Jun 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants