This repository was archived by the owner on Oct 13, 2021. It is now read-only.
Add unit tests for upsample and pool #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinitra-zz
reviewed
Jun 3, 2019
| @@ -46,7 +38,7 @@ def convert_keras_upsample(scope, operator, container, n_dims): | |||
|
|
|||
| # If channels_first is True, we don't need to permute the output of ONNX Upsample. Otherwise, similar to Crop's | |||
| # conversion, a Transpose would be added. | |||
There was a problem hiding this comment.
update channels_first comments to indicate change to no_permutation_required
vinitra-zz
reviewed
Jun 3, 2019
| attrs['op_version'] = op_version | ||
| # In ONNX opset 10, the ceil_mode attribute was added to local MaxPool and AveragePool | ||
| if container.target_opset >= 10: | ||
| attrs['ceil_mode'] = 0 |
There was a problem hiding this comment.
Thanks for adding the ceil_mode opset10 changes! I can close my PR #96.
|
LGTM, after it passes the CI tests! Thanks for merging my changes from #96 into this PR. Will focus solely on thresholdedReLU in that PR. |
vinitra-zz
approved these changes
Jun 3, 2019
…into test_upsample
…into test_upsample
…into test_upsample
…into test_upsample
vinitra-zz
pushed a commit
to vinitra-zz/keras-onnx
that referenced
this pull request
Jun 3, 2019
…into test_upsample
…into test_upsample
…into test_upsample
…into test_upsample
…into test_upsample
…into test_upsample
…into test_upsample
…into test_upsample
wenbingl
pushed a commit
that referenced
this pull request
Oct 22, 2019
fix batch norm mean/var dimention issue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.