Skip to content

refactor: move example from otelmux to make it a testable example #7121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 19, 2025

Conversation

noetarbouriech
Copy link
Contributor

@noetarbouriech noetarbouriech commented Apr 2, 2025

Resolves #7064

I simply moved the old example to have it shown on the pkg.go.dev page. It will require testing for metrics in the future.

@noetarbouriech noetarbouriech requested a review from a team as a code owner April 2, 2025 16:24
Copy link

linux-foundation-easycla bot commented Apr 2, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot requested a review from akats7 April 2, 2025 16:24
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.6%. Comparing base (158bafc) to head (94a8c4b).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #7121     +/-   ##
=======================================
+ Coverage   81.5%   81.6%   +0.1%     
=======================================
  Files        206     205      -1     
  Lines      18270   18231     -39     
=======================================
- Hits       14891   14885      -6     
+ Misses      2959    2924     -35     
- Partials     420     422      +2     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@noetarbouriech noetarbouriech changed the title refactor(example): move example to make it a testable example refactor: move example from otelmux to make it a testable example Apr 2, 2025
Copy link
Member

@dmathieu dmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the conflicts?

@dmathieu
Copy link
Member

Ping @noetarbouriech to update the PR so we can review/merge it?

@pellared pellared added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label May 19, 2025
@dmathieu dmathieu merged commit 2896fea into open-telemetry:main May 19, 2025
27 checks passed
@MrAlias MrAlias added this to the v1.36.0 milestone May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example for otelmux
5 participants