-
Notifications
You must be signed in to change notification settings - Fork 668
refactor: move example from otelgin to make it a testable example #7328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Move the example from otelgin to be displayed in godocs. Resolves: open-telemetry#7063
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7328 +/- ##
=======================================
+ Coverage 81.2% 81.4% +0.2%
=======================================
Files 207 206 -1
Lines 18275 18230 -45
=======================================
Hits 14845 14845
+ Misses 3008 2963 -45
Partials 422 422 🚀 New features to boost your workflow:
|
Thank you for your contribution. I don't think we need to remove the examples. What I believe we should do is: simply add examples based on the Just wanted to confirm, is this what we need? @pellared |
PS: To facilitate testing whether the desired effect is achieved, you can use this tool for debugging: https://github.com/golang/pkgsite |
instrumentation/github.com/gin-gonic/gin/otelgin/example_test.go
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also follows: #7118
Following this PR, this moves the example from otelgin to be displayed in godocs.
Resolves: #7063