Fix all issues from shellcheck --severity=warning #2354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
xrmx
approved these changes
Mar 19, 2024
|
Test is failing from an unrelated change. Wait unitl this is merged. |
I think this would be a great thing to have. Feel free to include that as part of this pr. |
👍 |
xrmx
approved these changes
Apr 5, 2024
xrmx
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Run
shellcheck --severity=warningand fix all issues - some from main repo, a dead variable, a safety check to make surerm -rfdoesn't erase the file system, etc.If desired, I could add a PR for enabling a shellcheck CI step similar to open-telemetry/opentelemetry-lambda#396
Does This PR Require a Core Repo Change?
Some scripts from the core repo also changed, linking both directions for completeness: