Fix shellcheck --severity=warning issues #3789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
2 tasks
xrmx
approved these changes
Mar 20, 2024
|
Thanks @johnbley, that PR for CI checking is a great idea! |
ocelotl
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Run
shellcheck --severity=warningon all build scripts. Fix a quoting issue, remove some dead code, and safely ensure that the build can't ever accidentally wipe the file system.If desired, I could add a PR for enabling a shellcheck CI step similar to open-telemetry/opentelemetry-lambda#396
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
Scripts in
scripts/that were copied over to the Contrib repo have changed(Yes, and Contrib also has additional shellcheck errors/warnings in non-shared scripts)
Yes. - Link to PR: contrib shellcheck warnings
No.