Skip to content

NO-JIRA: tests(gha/k8s): remove setting the node-role.kubernetes.io/control-plane taint #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

jiridanek
Copy link
Member

@jiridanek jiridanek commented May 9, 2025

Description

For some reason, the kubeadm.yaml was setting the taint only for build-notebooks-TEMPLATE.yaml to immediately unset it. This became obvious after migrating to v1beta4 kubeadm.yaml

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from dibryant and harshad16 May 9, 2025 12:15
Copy link
Contributor

openshift-ci bot commented May 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jiridanek for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added size/xs and removed size/xs labels May 9, 2025
…control-plane` taint

For some reason, the `kubeadm.yaml` was setting the taint only for `build-notebooks-TEMPLATE.yaml` to immediately unset it.
@caponetto
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 9, 2025
@jiridanek jiridanek merged commit c8b73af into opendatahub-io:main May 9, 2025
8 of 10 checks passed
@jiridanek jiridanek deleted the ghak8s branch May 9, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants