Skip to content

NO-JIRA: tests(gha/k8s): remove setting the node-role.kubernetes.io/control-plane taint #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

NO-JIRA: tests(gha/k8s): remove setting the node-role.kubernetes.io/control-plane taint #1068

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/workflows/build-notebooks-TEMPLATE.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,10 +471,6 @@ jobs:
# Once you have found the failing container, you can inspect its logs with:
# crictl --runtime-endpoint unix:///var/run/crio/crio.sock logs CONTAINERID

- name: Untaint the master
if: ${{ steps.have-tests.outputs.tests == 'true' }}
run: kubectl taint nodes --all node-role.kubernetes.io/control-plane-

- name: Show nodes status and wait for readiness
if: ${{ steps.have-tests.outputs.tests == 'true' }}
run: |
Expand Down
4 changes: 1 addition & 3 deletions ci/cached-builds/kubeadm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@ nodeRegistration:
criSocket: unix:///var/run/crio/crio.sock
imagePullPolicy: IfNotPresent
imagePullSerial: true
taints:
- effect: NoSchedule
key: node-role.kubernetes.io/control-plane
taints: []
kubeletExtraArgs:
# Need to have enough disk space for Kubelet, so move root-dir on the LVM volume
# Note: the internets discourage from changing the default because storage plugins may then struggle
Expand Down