-
Notifications
You must be signed in to change notification settings - Fork 547
OCPBUGS-55652: Remove PrivateHostedZoneAWS feature gate #2338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @Thealisyed! Some important instructions when contributing to openshift/api: |
@Thealisyed: This pull request references Jira Issue OCPBUGS-55652, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
You'll need to run Have all references to this gate been removed from the operator/installer codebases? |
The PrivateHostedZoneAWS gate is being removed The feature gate was at first introduced as TPNU in OpenShift 4.14 and was promoted to Default in the same release. The feature gate has been enabled by default for over 3 releases, so it is scheduled to be removed imminently
Thanks, updated after running |
Removed from installer in openshift/installer#7327 |
/retest-required |
Verified using pre-image build
|
/label qe-approved |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, Thealisyed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold Revision b2a79c2 was retested 3 times: holding |
/retest-required |
Note that the openshift/api PR depends on openshift/cluster-ingress-operator#1230 to merge first. |
/retest-required |
/retest-required |
1 similar comment
/retest-required |
/hold cancel Dependent PR merged /retest-required |
1 similar comment
/retest-required |
/retest-required |
/hold The upgrade minor e2e job is misconfigured, I'll release this once I have updated the job |
/hold cancel |
/test minor-e2e-upgrade-minor |
@Thealisyed: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest-required |
74a8f24
into
openshift:master
@Thealisyed: Jira Issue OCPBUGS-55652: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-55652 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-config-api |
The PrivateHostedZoneAWS gate is being removed
The feature gate was at first introduced as TPNU
in OpenShift 4.14 and was promoted to Default
in the same release.
The feature gate has been enabled by default for
over 3 releases, so it is scheduled
to be removed imminently