Skip to content

OCPBUGS-55652: Remove PrivateHostedZoneAWS feature gate #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

Thealisyed
Copy link

The PrivateHostedZoneAWS gate is being removed
The feature gate was at first introduced as TPNU
in OpenShift 4.14 and was promoted to Default
in the same release.
The feature gate has been enabled by default for
over 3 releases, so it is scheduled
to be removed imminently

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 22, 2025
Copy link
Contributor

openshift-ci bot commented May 22, 2025

Hello @Thealisyed! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 22, 2025
@openshift-ci-robot
Copy link

@Thealisyed: This pull request references Jira Issue OCPBUGS-55652, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @melvinjoseph86

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The PrivateHostedZoneAWS gate is being removed
The feature gate was at first introduced as TPNU
in OpenShift 4.14 and was promoted to Default
in the same release.
The feature gate has been enabled by default for
over 3 releases, so it is scheduled
to be removed imminently

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from melvinjoseph86 May 22, 2025 12:10
@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 22, 2025
@openshift-ci openshift-ci bot requested review from deads2k and JoelSpeed May 22, 2025 12:11
@JoelSpeed
Copy link
Contributor

You'll need to run make update, but otherwise this seems fine

Have all references to this gate been removed from the operator/installer codebases?

The PrivateHostedZoneAWS gate is being removed
The feature gate was at first introduced as TPNU
in OpenShift 4.14 and was promoted to Default
in the same release.
The feature gate has been enabled by default for
over 3 releases, so it is scheduled
to be removed imminently
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 22, 2025
@Thealisyed
Copy link
Author

Thanks, updated after running make update.
Couldn't see anything in openshift/installer myself but will double check with installer team @JoelSpeed

@patrickdillon
Copy link
Contributor

You'll need to run make update, but otherwise this seems fine

Have all references to this gate been removed from the operator/installer codebases?

Removed from installer in openshift/installer#7327

@melvinjoseph86
Copy link

/retest-required

@melvinjoseph86
Copy link

Verified using pre-image build

mjoseph@mjoseph-mac Downloads % oc get clusterversion
NAME      VERSION                                                AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.20.0-0-2025-05-26-050211-test-ci-ln-kyvjfwt-latest   True        False         45m     Cluster version is 4.20.0-0-2025-05-26-050211-test-ci-ln-kyvjfwt-latest

mjoseph@mjoseph-mac Downloads % 
mjoseph@mjoseph-mac Downloads % 
mjoseph@mjoseph-mac Downloads % oc get featuregates.config.openshift.io cluster -oyaml
apiVersion: config.openshift.io/v1
kind: FeatureGate
metadata:
  annotations:
    include.release.openshift.io/self-managed-high-availability: "true"
  creationTimestamp: "2025-05-26T05:19:03Z"
  generation: 1
  name: cluster
  resourceVersion: "684"
  uid: 50d55875-bdba-4cef-bd9b-153430884429
spec: {}
status:
  featureGates:
  - disabled:
    - name: AWSClusterHostedDNS
    - name: AWSDedicatedHosts
    - name: AutomatedEtcdBackup
    - name: AzureMultiDisk
    - name: BootcNodeManagement
    - name: ClusterAPIInstall
    - name: ClusterAPIInstallIBMCloud
    - name: ClusterMonitoringConfig
    - name: ClusterVersionOperatorConfiguration
    - name: DNSNameResolver
    - name: DualReplica
    - name: DyanmicServiceEndpointIBMCloud
    - name: DynamicResourceAllocation
    - name: EtcdBackendQuota
    - name: EventedPLEG
    - name: Example
    - name: Example2
    - name: ExternalOIDC
    - name: ExternalOIDCWithUIDAndExtraClaimMappings
    - name: GCPClusterHostedDNS
    - name: GCPCustomAPIEndpoints
    - name: HighlyAvailableArbiter
    - name: ImageStreamImportMode
    - name: IngressControllerDynamicConfigurationManager
    - name: InsightsConfig
    - name: InsightsConfigAPI
    - name: InsightsOnDemandDataGather
    - name: InsightsRuntimeExtractor
    - name: KMSEncryptionProvider
    - name: MachineAPIMigration
    - name: MachineAPIOperatorDisableMachineHealthCheckController
    - name: MachineConfigNodes
    - name: ManagedBootImagesvSphere
    - name: MaxUnavailableStatefulSet
    - name: MinimumKubeletVersion
    - name: MixedCPUsAllocation
    - name: MultiArchInstallAzure
    - name: NewOLMCatalogdAPIV1Metas
    - name: NewOLMOwnSingleNamespace
    - name: NewOLMPreflightPermissionChecks
    - name: NewOLMWebhookProviderOpenshiftServiceCA
    - name: NodeSwap
    - name: NutanixMultiSubnets
    - name: OVNObservability
    - name: PinnedImages
    - name: PlatformOperators
    - name: RouteAdvertisements
    - name: SELinuxMount
    - name: ShortCertRotation
    - name: SignatureStores
    - name: SigstoreImageVerification
    - name: SigstoreImageVerificationPKI
    - name: TranslateStreamCloseWebsocketRequests
    - name: UpgradeStatus
    - name: VSphereConfigurableMaxAllowedBlockVolumesPerNode
    - name: VSphereHostVMGroupZonal
    - name: VSphereMixedNodeEnv
    - name: VSphereMultiDisk
    - name: VSphereMultiNetworks
    - name: VolumeAttributesClass
    - name: VolumeGroupSnapshot
    enabled:
    - name: AWSEFSDriverVolumeMetrics
    - name: AdditionalRoutingCapabilities
    - name: AdminNetworkPolicy
    - name: AlibabaPlatform
    - name: AzureWorkloadIdentity
    - name: BuildCSIVolumes
    - name: CPMSMachineNamePrefix
    - name: ChunkSizeMiB
    - name: ConsolePluginContentSecurityPolicy
    - name: GCPLabelsTags
    - name: GatewayAPI
    - name: GatewayAPIController
    - name: HardwareSpeed
    - name: IngressControllerLBSubnetsAWS
    - name: KMSv1
    - name: ManagedBootImages
    - name: ManagedBootImagesAWS
    - name: MetricsCollectionProfiles
    - name: MultiArchInstallAWS
    - name: NetworkDiagnosticsConfig
    - name: NetworkLiveMigration
    - name: NetworkSegmentation
    - name: NewOLM
    - name: NodeDisruptionPolicy
    - name: OnClusterBuild
    - name: OpenShiftPodSecurityAdmission
    - name: PersistentIPsForVirtualization
    - name: ProcMountType
    - name: RouteExternalCertificate
    - name: ServiceAccountTokenNodeBinding
    - name: SetEIPForNLBIngressController
    - name: UserNamespacesPodSecurityStandards
    - name: UserNamespacesSupport
    - name: ValidatingAdmissionPolicy
    version: 4.20.0-0-2025-05-26-050211-test-ci-ln-kyvjfwt-latest

@melvinjoseph86
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 26, 2025
@Thealisyed
Copy link
Author

/retest

@JoelSpeed
Copy link
Contributor

/lgtm
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2025
Copy link
Contributor

openshift-ci bot commented May 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, Thealisyed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f5e205b and 2 for PR HEAD b2a79c2 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3085657 and 1 for PR HEAD b2a79c2 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3085657 and 2 for PR HEAD b2a79c2 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD bb0d66d and 1 for PR HEAD b2a79c2 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a463917 and 0 for PR HEAD b2a79c2 in total

@openshift-ci-robot
Copy link

/hold

Revision b2a79c2 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2025
@Thealisyed
Copy link
Author

/retest-required

@Miciah
Copy link
Contributor

Miciah commented May 29, 2025

Note that the openshift/api PR depends on openshift/cluster-ingress-operator#1230 to merge first.

@Thealisyed
Copy link
Author

/retest-required

@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 29, 2025
@Thealisyed
Copy link
Author

/retest-required

1 similar comment
@Thealisyed
Copy link
Author

/retest-required

@JoelSpeed
Copy link
Contributor

/hold cancel

Dependent PR merged

/retest-required

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a0fb5f4 and 2 for PR HEAD b2a79c2 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD a0fb5f4 and 2 for PR HEAD b2a79c2 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 017e9dd and 1 for PR HEAD b2a79c2 in total

@Thealisyed
Copy link
Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 017e9dd and 2 for PR HEAD b2a79c2 in total

@Thealisyed
Copy link
Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2b129d9 and 1 for PR HEAD b2a79c2 in total

@JoelSpeed
Copy link
Contributor

/hold

The upgrade minor e2e job is misconfigured, I'll release this once I have updated the job

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2025
@JoelSpeed
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 9, 2025
@JoelSpeed
Copy link
Contributor

/test minor-e2e-upgrade-minor

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c8c30d5 and 2 for PR HEAD b2a79c2 in total

Copy link
Contributor

openshift-ci bot commented Jun 9, 2025

@Thealisyed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp b2a79c2 link false /test e2e-gcp
ci/prow/okd-scos-e2e-aws-ovn b2a79c2 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-azure b2a79c2 link false /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit 74a8f24 into openshift:master Jun 10, 2025
23 of 26 checks passed
@openshift-ci-robot
Copy link

@Thealisyed: Jira Issue OCPBUGS-55652: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-55652 has been moved to the MODIFIED state.

In response to this:

The PrivateHostedZoneAWS gate is being removed
The feature gate was at first introduced as TPNU
in OpenShift 4.14 and was promoted to Default
in the same release.
The feature gate has been enabled by default for
over 3 releases, so it is scheduled
to be removed imminently

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.20.0-202506101415.p0.g74a8f24.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants