Bump golang dependency to 1.19 #307
Conversation
openshift-ci
bot
added
the
approved
|
Bumping golang version for CI here - openshift/release#36861 |
|
/retest |
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
There was a problem hiding this comment.
CI saves the day:
Pulling image registry.ci.openshift.org/openshift/release:rhel-8-release-golang-1.17-openshift-4.10 ...
Trying to pull registry.ci.openshift.org/openshift/release:rhel-8-release-golang-1.17-openshift-4.10...
Getting image source signatures
...
and then:
go build -o build/controller-gen ./vendor/sigs.k8s.io/controller-tools/cmd/controller-gen
# k8s.io/apimachinery/third_party/forked/golang/reflect
vendor/k8s.io/apimachinery/third_party/forked/golang/reflect/deep_equal.go:376:7: undefined: reflect.Pointer
note: module requires Go 1.19
# k8s.io/apimachinery/pkg/util/set
so it looks like we also need to update Dockerfile.ci and tell it to use rhel-8-release-golang-1.19-openshift-4.12 instead?
We were using 1.16, which ended support 11 months ago. Let's update the version of go we use and also update the dependencies we use (fixing vulnerabilities caught by dependabot). You can verify the contents of this commit using: $ make clean // bump go version in go.mod $ go get -u all // fix resolution issues manually $ go mod go_mod $ go mod vendor
Aha - good call. I forgot about that hook. Thanks! |
|
@rhmdnd: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jhrozek, rhmdnd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We were using 1.16, which ended support 11 months ago. Let's update the
version of go we use and also update the dependencies we use (fixing
vulnerabilities caught by dependabot).
You can verify the contents of this commit using:
$ make clean // bump go version in go.mod
$ go get -u all // fix resolution issues manually
$ go mod go_mod
$ go mod vendor