Skip to content

Use golang 1.19 and OCP 4.12 for FIO CI #36861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

rhmdnd
Copy link
Contributor

@rhmdnd rhmdnd commented Mar 2, 2023

We need to use a newer version of golang to address dependency vulnerabilities.

We need to use a newer version of golang to address dependency
vulnerabilities.
@rhmdnd
Copy link
Contributor Author

rhmdnd commented Mar 2, 2023

Actual version dependencies are getting bumped here - openshift/file-integrity-operator#307

@openshift-ci-robot
Copy link
Contributor

@rhmdnd: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-file-integrity-operator-master-ci-index-file-integrity-operator-bundle openshift/file-integrity-operator presubmit Ci-operator config changed
pull-ci-openshift-file-integrity-operator-master-e2e-aws openshift/file-integrity-operator presubmit Ci-operator config changed
pull-ci-openshift-file-integrity-operator-master-e2e-bundle-aws openshift/file-integrity-operator presubmit Ci-operator config changed
pull-ci-openshift-file-integrity-operator-master-e2e-bundle-aws-upgrade openshift/file-integrity-operator presubmit Ci-operator config changed
pull-ci-openshift-file-integrity-operator-master-go-build openshift/file-integrity-operator presubmit Ci-operator config changed
pull-ci-openshift-file-integrity-operator-master-images openshift/file-integrity-operator presubmit Ci-operator config changed
pull-ci-openshift-file-integrity-operator-master-unit openshift/file-integrity-operator presubmit Ci-operator config changed
pull-ci-openshift-file-integrity-operator-master-verify openshift/file-integrity-operator presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from Vincent056 and xiaojiey March 2, 2023 04:31
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2023
@rhmdnd
Copy link
Contributor Author

rhmdnd commented Mar 2, 2023

/pj-rehearse

@jhrozek
Copy link
Contributor

jhrozek commented Mar 2, 2023

/pj-rehearse pull-ci-openshift-file-integrity-operator-master-e2e-bundle-aws-upgrade

Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhrozek, rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhrozek
Copy link
Contributor

jhrozek commented Mar 2, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2023

@rhmdnd: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 09763e9 into openshift:master Mar 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2023

@rhmdnd: Updated the ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-file-integrity-operator-master.yaml using file ci-operator/config/openshift/file-integrity-operator/openshift-file-integrity-operator-master.yaml

In response to this:

We need to use a newer version of golang to address dependency vulnerabilities.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants