Skip to content

Release v1.3.4 #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2024
Merged

Release v1.3.4 #529

merged 2 commits into from
Oct 24, 2024

Conversation

rhmdnd
Copy link
Contributor

@rhmdnd rhmdnd commented May 13, 2024

No description provided.

@openshift-ci openshift-ci bot requested review from mkumku and xiaojiey May 13, 2024 22:12
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 29, 2024
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 28, 2024
@yuumasato
Copy link
Contributor

/retest

1 similar comment
@yuumasato
Copy link
Contributor

/retest

@yuumasato
Copy link
Contributor

@rhmdnd @Vincent056 Do we expect rosa tests to pass?

@yuumasato
Copy link
Contributor

@rhmdnd @Vincent056 Do we expect rosa tests to pass?

The e2e test is failing on cluster setup due to billing. 😓

yuumasato
yuumasato approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@yuumasato
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 10, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 06f1512 and 2 for PR HEAD 98271bc in total

@yuumasato
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 06f1512 and 2 for PR HEAD 98271bc in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 06f1512 and 2 for PR HEAD 98271bc in total

@yuumasato
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 06f1512 and 2 for PR HEAD 98271bc in total

@yuumasato
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 06f1512 and 2 for PR HEAD 98271bc in total

@yuumasato
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 06f1512 and 2 for PR HEAD 98271bc in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 06f1512 and 2 for PR HEAD 98271bc in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2f65965 and 2 for PR HEAD 98271bc in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2f65965 and 2 for PR HEAD 98271bc in total

@rhmdnd
Copy link
Contributor Author

rhmdnd commented Oct 17, 2024

/test e2e-bundle-aws

Retesting this since openshift/release#57904 landed.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2f65965 and 2 for PR HEAD 98271bc in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2f65965 and 2 for PR HEAD 98271bc in total

@rhmdnd @yuumasato
Use latest in the CSV instead of a version tag
e767293 
This makes it so that the replace logic also replaces the deployment
image in addition to the related image. This is necessary CI to work
properly, because it needs to be able to replace all images in the CSV
with a build from CI.
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2024
@rhmdnd rhmdnd removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 18, 2024
yuumasato
yuumasato approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@yuumasato
Copy link
Contributor

/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 21, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 4632e3c and 2 for PR HEAD e767293 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cd3850d and 2 for PR HEAD e767293 in total

3 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cd3850d and 2 for PR HEAD e767293 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cd3850d and 2 for PR HEAD e767293 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cd3850d and 2 for PR HEAD e767293 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 048c29f and 1 for PR HEAD e767293 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 94bd8c1 and 0 for PR HEAD e767293 in total

@openshift-ci-robot
Copy link

/hold

Revision e767293 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 23, 2024
@yuumasato
Copy link
Contributor

/retest-required

@yuumasato
Copy link
Contributor

/test e2e-bundle-aws

yuumasato
yuumasato approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, yuumasato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yuumasato
Copy link
Contributor

/test e2e-rosa

@yuumasato
Copy link
Contributor

/unhold

The CI should be in better condition now

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 24, 2024

@rhmdnd: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-rosa e767293 link false /test e2e-rosa

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0a96aa1 into master Oct 24, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuumasato yuumasato yuumasato approved these changes

@mkumku mkumku Awaiting requested review from mkumku

@xiaojiey xiaojiey Awaiting requested review from xiaojiey

Assignees

@yuumasato yuumasato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rhmdnd @openshift-bot @yuumasato @openshift-ci-robot