Skip to content

Simplify FIO bundle testing #57904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rhmdnd
Copy link
Contributor

@rhmdnd rhmdnd commented Oct 16, 2024

FIO bundle tests are currently broken because the bundle fails to
install:

install failed: deployment file-integrity-operator not ready before timeout: deployment "file-integrity-operator" exceeded its progress deadline

This commit overhauls the bundle test setup to follow the documented
procedures for testing bundles in the OpenShift CI documentation:

https://docs.ci.openshift.org/docs/how-tos/testing-operator-sdk-operators/#simple-operator-installation

@openshift-ci openshift-ci bot requested review from BhargaviGudi and mkumku October 16, 2024 21:02
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2024
@rhmdnd rhmdnd force-pushed the simplify-fio-bundle-testing branch from e7517fd to a4c5a51 Compare October 16, 2024 21:03
@rhmdnd
Copy link
Contributor Author

rhmdnd commented Oct 16, 2024

/pj-rehearse pull-ci-openshift-file-integrity-operator-master-e2e-bundle-aws

@openshift-ci-robot
Copy link
Contributor

@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

FIO bundle tests are currently broken because the bundle fails to
install:

  install failed: deployment file-integrity-operator not ready before timeout: deployment "file-integrity-operator" exceeded its progress deadline

This commit overhauls the bundle test setup to follow the documented
procedures for testing bundles in the OpenShift CI documentation:

  https://docs.ci.openshift.org/docs/how-tos/testing-operator-sdk-operators/#simple-operator-installation
@rhmdnd rhmdnd force-pushed the simplify-fio-bundle-testing branch from a4c5a51 to a67a7e9 Compare October 16, 2024 23:28
@rhmdnd
Copy link
Contributor Author

rhmdnd commented Oct 16, 2024

/pj-rehearse pull-ci-openshift-file-integrity-operator-master-e2e-bundle-aws

@openshift-ci-robot
Copy link
Contributor

@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@rhmdnd: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-file-integrity-operator-master-ci-index-file-integrity-operator-bundle openshift/file-integrity-operator presubmit Ci-operator config changed
pull-ci-openshift-file-integrity-operator-master-e2e-aws openshift/file-integrity-operator presubmit Ci-operator config changed
pull-ci-openshift-file-integrity-operator-master-e2e-bundle-aws openshift/file-integrity-operator presubmit Ci-operator config changed
pull-ci-openshift-file-integrity-operator-master-e2e-bundle-aws-upgrade openshift/file-integrity-operator presubmit Ci-operator config changed
pull-ci-openshift-file-integrity-operator-master-e2e-rosa openshift/file-integrity-operator presubmit Ci-operator config changed
pull-ci-openshift-file-integrity-operator-master-go-build openshift/file-integrity-operator presubmit Ci-operator config changed
pull-ci-openshift-file-integrity-operator-master-images openshift/file-integrity-operator presubmit Ci-operator config changed
pull-ci-openshift-file-integrity-operator-master-unit openshift/file-integrity-operator presubmit Ci-operator config changed
pull-ci-openshift-file-integrity-operator-master-verify openshift/file-integrity-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

cli: latest
commands: |
oc create namespace openshift-file-integrity
operator-sdk run bundle --security-context-config restricted -n openshift-file-integrity "$OO_BUNDLE"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder with step would we need to change to Make file for e2e test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that the e2e suite doesn't install the operator?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe TEST_BUNDLE_INSTALL=1 bypasses the install procedure in the e2e suite.

Copy link
Contributor

openshift-ci bot commented Oct 17, 2024

@rhmdnd: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rhmdnd
Copy link
Contributor Author

rhmdnd commented Oct 17, 2024

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Oct 17, 2024
@rhmdnd
Copy link
Contributor Author

rhmdnd commented Oct 17, 2024

cc @yuumasato for awareness, should be ready for a review.

Copy link
Contributor

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2024
Copy link
Contributor

openshift-ci bot commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, yuumasato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7f4626d into openshift:master Oct 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants