-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Simplify FIO bundle testing #57904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify FIO bundle testing #57904
Conversation
e7517fd
to
a4c5a51
Compare
/pj-rehearse pull-ci-openshift-file-integrity-operator-master-e2e-bundle-aws |
@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
FIO bundle tests are currently broken because the bundle fails to install: install failed: deployment file-integrity-operator not ready before timeout: deployment "file-integrity-operator" exceeded its progress deadline This commit overhauls the bundle test setup to follow the documented procedures for testing bundles in the OpenShift CI documentation: https://docs.ci.openshift.org/docs/how-tos/testing-operator-sdk-operators/#simple-operator-installation
a4c5a51
to
a67a7e9
Compare
/pj-rehearse pull-ci-openshift-file-integrity-operator-master-e2e-bundle-aws |
@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
cli: latest | ||
commands: | | ||
oc create namespace openshift-file-integrity | ||
operator-sdk run bundle --security-context-config restricted -n openshift-file-integrity "$OO_BUNDLE" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder with step would we need to change to Make file for e2e test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So that the e2e suite doesn't install the operator?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe TEST_BUNDLE_INSTALL=1
bypasses the install procedure in the e2e suite.
@rhmdnd: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Got a clean e2e run with a bundle install: |
/pj-rehearse ack |
@rhmdnd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
cc @yuumasato for awareness, should be ready for a review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, yuumasato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
FIO bundle tests are currently broken because the bundle fails to
install:
install failed: deployment file-integrity-operator not ready before timeout: deployment "file-integrity-operator" exceeded its progress deadline
This commit overhauls the bundle test setup to follow the documented
procedures for testing bundles in the OpenShift CI documentation:
https://docs.ci.openshift.org/docs/how-tos/testing-operator-sdk-operators/#simple-operator-installation