console autodetection #18
Conversation
openshift-ci-robot
added
the
size/M
|
depends on openshift/origin#18075 |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
TSB is installed after the console in openshift-ansible. We probably have force a redeploy of the console after TSB install since we're only checking it on console startup. @sdodson fyi |
|
This also depends on openshift-ansible changes to apply the console RBAC template. |
|
openshift-ansible changes: openshift/openshift-ansible#6706 |
| } | ||
| if cfg.ExtraConfig.TemplateServiceBrokerEnabled == nil { | ||
| enabled := false | ||
| _, err := restClient.RESTClient().Get().AbsPath("/apis/servicecatalog.k8s.io/v1beta1/clusterservicebrokers/template-service-broker").Do().Raw() |
There was a problem hiding this comment.
Will this work correctly if service catalog is not installed?
There was a problem hiding this comment.
Will this work correctly if service catalog is not installed?
Yes, it will return a 404 and simply set itself to "enabled=false"
|
Currently in cluster up and in an ansible install, the web console is installed before template service broker. We'll have to decide how to handle that since detection will fail on first run. We might just move the console install until after service catalog and brokers. |
|
Does service broker failure will affect web console installation if we move console after service catalog and broker? Seems not, web console only need detect if TSB is enabled or not, no matter service broker status, is this the case? @spadgett |
|
No, the only bad effect is that the templates will show up twice in the catalog. We'll look at working around that limitation, however. We might need redeploy the console after the service catalog playbook since it can be run separately. |
Automatic merge from submit-queue. Add console RBAC template Required for openshift/origin-web-console-server#18 Origin changes: openshift/origin#18075 /assign @sdodson /cc @deads2k
|
The openshift-ansible changes merged |
Automatic merge from submit-queue (batch tested with PRs 18075, 17725, 16766, 18070, 18113). allow webconsole to discover cluster information Adds permissions to the webconsole to inspect what clusterservicebrokers are present. @pmorie please confirm this is a non-escalating resource which can be generally viewed. @openshift/sig-security @spadgett @jwforres you'll need this before merging openshift/origin-web-console-server#18
|
openshift/origin#18075 has merged /hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
Automatic merge from submit-queue (batch tested with PRs 18163, 18139, 18193, 18194, 16180). cluster up: install console after template service broker The console will check if the template service broker is running, but only on startup. Install the console after the broker so that this check works for `oc cluster up --service-catalog`. /assign @deads2k cc @jwforres See openshift/origin-web-console-server#18 See https://bugzilla.redhat.com/show_bug.cgi?id=1534316
Adds auto-detection (on startup only!) for kube version, openshift version, and TSB detection.
/assign spadgett
@jwforres fyi