Skip to content

cluster up: install console after template service broker #18163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2018
Merged

cluster up: install console after template service broker #18163

merged 1 commit into from
Jan 20, 2018

Conversation

spadgett
Copy link
Member

The console will check if the template service broker is running, but
only on startup. Install the console after the broker so that this check
works for oc cluster up --service-catalog.

/assign @deads2k
cc @jwforres

See openshift/origin-web-console-server#18
See https://bugzilla.redhat.com/show_bug.cgi?id=1534316

@spadgett
cluster up: install console after template service broker
c6f8e94 
The console will check if the template service broker is running, but
only on startup. Install the console after the broker so that this check
works for `oc cluster up --service-catalog`.
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2018
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 18, 2018
@spadgett
Copy link
Member Author

Not sure what caused this. The tests ran, and I don't see any failures.

https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/18163/test_pull_request_origin_unit/8200/

Of 7905 tests executed in 2796.595s, 7881 succeeded, 0 failed, and 24 were skipped.
...
[WARNING] While the jUnit report found no failed tests, the `go test` process failed.
[WARNING] This usually means that the unit test suite failed to compile.

@stevekuznetsov FYI

/test unit

@spadgett
Copy link
Member Author

flake #17556

/test extended_conformance_install

@spadgett
Copy link
Member Author

flake #13829

/retest

@stevekuznetsov
Copy link
Contributor

Looks like we lost some output from go test in that run... the file containing stdout for the go test process doesn't end cleanly

@jwforres
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwforres, spadgett

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 18163, 18139, 18193, 18194, 16180).

@openshift-merge-robot openshift-merge-robot merged commit 7d8519e into openshift:master Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

@coreydaley coreydaley Awaiting requested review from coreydaley

Assignees

@jwforres jwforres

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@spadgett @stevekuznetsov @jwforres @openshift-ci-robot @openshift-merge-robot @deads2k