Update overview to use toast notifications #1654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[test] |
jwforres
reviewed
Jun 6, 2017
| message: _.capitalize(buildType) + " " + buildName + " successfully created.", | ||
| links: [{ | ||
| href: buildURL, | ||
| label: 'View ' + _.capitalize(buildType) |
There was a problem hiding this comment.
any reason to not have the View Log link here?
There was a problem hiding this comment.
The reason I linked to the build instead of the log is because the build might not start immediately. But I'm not against changing it.
|
rebased |
|
Evaluated for origin web console test up to eab985c |
jwforres
approved these changes
Jun 6, 2017
|
[merge] |
|
Evaluated for origin web console merge up to eab985c |
|
Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1474/) (Base Commit: 9ca02da) |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1476/) (Base Commit: 09106a3) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/6WVJdgjL