Bug 1462205 - Delete binding shouldn't show up when all bindings are pending deletion #1738
Conversation
app/scripts/controllers/overview.js
Outdated
| @@ -1101,6 +1101,7 @@ function OverviewController($scope, | |||
| // - API objects by binding name | |||
| state.bindingsByApplicationUID = {}; | |||
| state.applicationsByBinding = {}; | |||
| state.validBindingsByApplicationUID = {}; | |||
There was a problem hiding this comment.
im not in love with the variable names here or in service-row, open to other suggestions
There was a problem hiding this comment.
I don't have a great suggestion :(
valid sort of implies ready to me... deleteableBindingsByApplicationUID too on the nose?
There was a problem hiding this comment.
yeah i started to call it undeletedBindingsByApplicationUID, its just... weird
There was a problem hiding this comment.
This is specifically for the delete binding action, so I don't mind a name that makes that clear even if it doesn't roll off the tongue.
Alternatively we could put the filter in overview-list-row and call it deleteableBindings.
|
This also fixes the text display to say Deleting with the spinner instead of Pending |
jwforres
force-pushed
the
bug-1462205-delete-binding
branch
from
3c9de65 to
25f3640
Compare
|
@spadgett updated the variable names, I also changed it to only pass the deleteable bindings into the unbind service directive |
|
@benjaminapetersen FYI, probably conflicts with #1742 |
|
[merge][severity:blocker] |
|
Evaluated for origin web console merge up to 25f3640 |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_web_console/1575/) (Base Commit: 95a85d3) (PR Branch Commit: 25f3640) (Extended Tests: blocker) |
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1462205