Skip to content

Bug 1368869 - Use toast notifications for build config env editor #1804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2017

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Jul 7, 2017

@spadgett spadgett requested a review from jwforres July 7, 2017 13:00
Copy link
Member

@jwforres jwforres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for 3.7

@spadgett spadgett changed the title Use toast notifications for build config and replica set env editors Bug 1368869 - Use toast notifications for build config and replica set env editors Jul 7, 2017
@openshift-bot openshift-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 14, 2017
@spadgett spadgett removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2017
@spadgett spadgett changed the title Bug 1368869 - Use toast notifications for build config and replica set env editors [WIP] Bug 1368869 - Use toast notifications for build config and replica set env editors Jul 16, 2017
@spadgett
Copy link
Member Author

Adding WIP because this will conflict with #1821

@spadgett spadgett changed the title [WIP] Bug 1368869 - Use toast notifications for build config and replica set env editors Bug 1368869 - Use toast notifications for build config env editor Jul 20, 2017
@spadgett
Copy link
Member Author

Rolled back the replica set changes since they were already part of #1821

@spadgett
Copy link
Member Author

[merge][severity: bug]

@openshift-bot
Copy link

Evaluated for origin web console merge up to 39a87ff

@openshift-bot
Copy link

openshift-bot commented Jul 20, 2017

Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/30/) (Base Commit: c9b410c) (PR Branch Commit: 39a87ff) (Extended Tests: bug)

@openshift-bot openshift-bot merged commit 3ba3853 into openshift:master Jul 20, 2017
@spadgett spadgett deleted the edit-env-toasts branch July 20, 2017 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants