Create reusable edit-environment-variables component #1821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
force-pushed
the
environment-editor-component
branch
2 times, most recently
from
92a3782 to
f76ba4b
Compare
spadgett
changed the title
spadgett
force-pushed
the
environment-editor-component
branch
2 times, most recently
from
885d88b to
e8cad32
Compare
|
may want to let QE know to regression test the env editors since its a lot of changes |
This was referenced Jul 11, 2017
openshift-bot
added
the
needs-rebase
spadgett
force-pushed
the
environment-editor-component
branch
2 times, most recently
from
79bbe31 to
1491e66
Compare
spadgett
removed
the
needs-rebase
|
[test] |
|
[merge] |
- Add environment variable support to stateful sets - Remove duplicate code from controllers - Fix problem where the enter key did not submit the environment form - Fix editor flicker on save
spadgett
force-pushed
the
environment-editor-component
branch
from
1491e66 to
b5b8f50
Compare
|
Evaluated for origin web console test up to b5b8f50 |
|
Rebased to fix merge conflict (which is why it failed). [merge] |
|
Evaluated for origin web console merge up to b5b8f50 |
|
Origin Web Console Test Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin_web_console/15/) (Base Commit: cfb6f13) (PR Branch Commit: b5b8f50) |
|
Origin Web Console Merge Results: SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin_web_console/29/) (Base Commit: 5d48301) (PR Branch Commit: b5b8f50) |
|
@jwforres created a card for QE: https://trello.com/c/3GxVdfi4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would replace #1815 and #1803
cc @jwforres