Skip to content

[WIP] Proposal: Move docker-registry to separate repository #10818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

legionus
Copy link
Contributor

@legionus legionus commented Sep 6, 2016

No description provided.

@legionus
Copy link
Contributor Author

legionus commented Sep 6, 2016

@mfojtik @miminar @soltysh PTAL

### code-base

The `origin` interacts with the docker-registry only through client library (no internal calls),
but this cannot be said about docker-regisrty.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/regisrty/registry/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@miminar
Copy link

miminar commented Sep 7, 2016

@legionus
Copy link
Contributor Author

legionus commented Sep 7, 2016

  • Pick-up a new registry repository name.

origin-registry ?

  • How will this affect spec file?

probably we will have own spec-file in the new repository.

  • What will we do with registry-related end-to-end tests?

I think they should stay in origin.

I don't know yet.

@legionus legionus force-pushed the proposal-docker-registry-split branch from 03defdb to c36b9f2 Compare September 7, 2016 13:39
@mfojtik
Copy link
Contributor

mfojtik commented Sep 26, 2016

@smarterclayton @ncdc PTAL


### etcd

The docker-registry does not have its own `etcd`. All metadata are stored to the `origin` database using
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth to mention the problem with storage if we continue using the openshift etcd.


1. docker-registry should use [clientsets](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/generating-clientset.md)
of `origin`.
2. docker-registry should use [clientsets](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/generating-clientset.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of `origin`.
2. docker-registry should use [clientsets](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/generating-clientset.md)
of `kubernetes`.
3. We need to create versioned client (clientsets?) for docker-registry as well.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is docker/engine-api not enough? or we are talking about adding more API endpoints to registry?

2. docker-registry should use [clientsets](https://github.com/kubernetes/kubernetes/blob/master/docs/devel/generating-clientset.md)
of `kubernetes`.
3. We need to create versioned client (clientsets?) for docker-registry as well.
4. We need to split some utilities to reduce the number of dependencies to `origin`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you talking about the build utilities?

of `kubernetes`.
3. We need to create versioned client (clientsets?) for docker-registry as well.
4. We need to split some utilities to reduce the number of dependencies to `origin`.
5. We need to make common framework for tests. Currently docker-registry uses a common test utilities and clients.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also start enabling the upstream docker-registry tests. we also need to enable the tests for different storage drivers to prove the storage works (remember GCS? :-)

i think this should be also mentioned here as part of the new infrastructure.


Use versioning clients will allow us maintain compatibility between repositories. In this case,
in the jenkins job for `origin` we can build the image from the separate repository before build and
test `origin` itself. Right now we make docker-registry image from the `origin` repository.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should also reduce the size of docker-registry right? (when we start not importing stuff from origin).

do we also need a regression tests (iow. registry vs. old version of origin).

@legionus
Copy link
Contributor Author

@pweil-
Copy link

pweil- commented Jun 26, 2017

closing due to inactivity

@pweil- pweil- closed this Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants