Extended deployment timeout #11729
Extended deployment timeout #11729
Conversation
| @@ -152,7 +152,8 @@ var _ = g.Describe("deploymentconfigs", func() { | |||
| o.Expect(err).NotTo(o.HaveOccurred()) | |||
|
|
|||
| g.By(fmt.Sprintf("by checking that the second deployment exists")) | |||
| err = wait.PollImmediate(500*time.Millisecond, 30*time.Second, func() (bool, error) { | |||
| // TODO when #11016 gets fixed this can be reverted to 30seconds | |||
| err = wait.PollImmediate(500*time.Millisecond, 1*time.Minute, func() (bool, error) { | |||
There was a problem hiding this comment.
add a comment to that issue and open the revert PR so we don't forget
There was a problem hiding this comment.
A bunch of the deployment tests have bumped timeouts, not sure if a single revert is enough. I would opt for a follow-up issue to #10228 where we should revisit times in all deployment tests.
|
LGTM |
|
Will do once we get to fix the issue On Wed, Nov 2, 2016 at 4:11 PM, Maciej Szulik [email protected]
|
|
@liggitt if that sounds good to you, can you please tag this one for merge? |
|
[test] |
|
Flake #11406. re-[test] |
|
flake: #10773 [test] |
|
Evaluated for origin test up to 185d7cf |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11049/) (Base Commit: 75ed7e1) |
|
@mfojtik merge this might drop the flake by one, at least |
|
[merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/11049/) (Image: devenv-rhel7_5309) |
|
Evaluated for origin merge up to 185d7cf |
This extended one of the timeouts we have in our deployment tests, I've noticed at least one occurrence, where the pod got into ready state right after we've timed out. Not sure how much this will help with #10228, but it's worth the shot at this point in time to decrease the level of flakes.
@mfojtik fyi