Skip to content

Extended deployment timeout #11729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2016
Merged

Extended deployment timeout #11729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/extended/deployments/deployments.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,8 @@ var _ = g.Describe("deploymentconfigs", func() {
o.Expect(err).NotTo(o.HaveOccurred())

g.By(fmt.Sprintf("by checking that the second deployment exists"))
err = wait.PollImmediate(500*time.Millisecond, 30*time.Second, func() (bool, error) {
// TODO when #11016 gets fixed this can be reverted to 30seconds
err = wait.PollImmediate(500*time.Millisecond, 1*time.Minute, func() (bool, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment to that issue and open the revert PR so we don't forget

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of the deployment tests have bumped timeouts, not sure if a single revert is enough. I would opt for a follow-up issue to #10228 where we should revisit times in all deployment tests.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/#10228/#11016/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened #11732 and added this PR there, @Kargakis can you add other changes you know of, so it's easier to nail them down faster.

_, rcs, _, err := deploymentInfo(oc, name)
if err != nil {
return false, nil
Expand Down