Skip to content

Bug 1415440: Check image history for zero size #12609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2017

Conversation

mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Jan 23, 2017

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1415440

@soltysh PTAL (I dunno what the case is when the history items is zero but this should prevent the panic. I will do more investigation.

@soltysh
Copy link
Contributor

soltysh commented Jan 23, 2017

@mfojtik the only time this array will be empty is when there was no import, yet. In all other cases this at least hast to point to the current image.

LGTM

[merge]

@mfojtik
Copy link
Contributor Author

mfojtik commented Jan 23, 2017

flake: #12605

[merge]

@mfojtik
Copy link
Contributor Author

mfojtik commented Jan 24, 2017

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 468c057

@openshift-bot
Copy link
Contributor

[Test]ing while waiting on the merge queue

@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 468c057

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13244/) (Base Commit: c5868ac)

1 similar comment
@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13244/) (Base Commit: c5868ac)

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 24, 2017

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13253/) (Base Commit: f861c25) (Image: devenv-rhel7_5763)

@openshift-bot openshift-bot merged commit 0c11501 into openshift:master Jan 24, 2017
@mfojtik mfojtik deleted the bz-1415440 branch September 5, 2018 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants