UPSTREAM: <carry>: Retry resource quota lookup until count stabilizes #12605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smarterclayton this seems reasonable to push upstream, imho. |
On contended servers the service account controller can slow down, leading to the count changing during a run. Wait up to 5s for the count to stabilize, assuming that updates come at a consistent rate, and are not held indefinitely.
smarterclayton
force-pushed
the
resource_quota
branch
from
8465b8b to
5aaf048
Compare
|
Evaluated for origin test up to 5aaf048 |
|
continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13201/) (Base Commit: 6bba78c) |
|
[merge] and will create a patch for upstream |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pr_origin/13201/) (Image: devenv-rhel7_5757) |
|
Evaluated for origin merge up to 5aaf048 |
k8s-github-robot
pushed a commit
to kubernetes/kubernetes
that referenced
this pull request
Jan 25, 2017
Automatic merge from submit-queue (batch tested with PRs 40215, 40340, 39523) Retry resource quota lookup until count stabilizes On contended servers the service account controller can slow down, leading to the count changing during a run. Wait up to 5s for the count to stabilize, assuming that updates come at a consistent rate, and are not held indefinitely. Upstream of openshift/origin#12605 (we create more secrets and flake more often)
|
@smarterclayton - did you have an upstream for this or should we create one? |
|
@smarterclayton nm, i cannot read a web page these days see the link above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On contended servers the service account controller can slow down,
leading to the count changing during a run. Wait up to 5s for the count
to stabilize, assuming that updates come at a consistent rate, and are
not held indefinitely.
Fixes #9414
[test]