Skip to content

Create an official admin command #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 26, 2015
Merged

Create an official admin command #1446

merged 2 commits into from
Mar 26, 2015

Conversation

smarterclayton
Copy link
Contributor

Move methods from 'ex' under it. Also makes overwrite-policy default
to a dry run.

@deads2k review

@smarterclayton smarterclayton mentioned this pull request Mar 25, 2015
Closed
@smarterclayton smarterclayton force-pushed the create_official_admin_command branch from ca1d7c7 to b5e06f8 Compare March 25, 2015 04:59
@deads2k
Copy link
Contributor

deads2k commented Mar 25, 2015

I'd like to fix up the policy command names when we move them.

add-user-to-role
add-group-to-role
remove-user-from-role
remove-group-from-role

Otherwise, lgtm.

@smarterclayton
Copy link
Contributor Author

I think we need to schedule a comprehensive review of all command names and set some patterns. Lots of "ex" stuff (and CLI stuff) is still pretty raw.

----- Original Message -----

I'd like to fix up the policy command names when we move them.

add-user-to-role
add-group-to-role
remove-user-from-role
remove-group-from-role

Otherwise, lgtm.

Reply to this email directly or view it on GitHub:
#1446 (comment)

@deads2k
Copy link
Contributor

deads2k commented Mar 25, 2015

@smarterclayton Can we fix those four in particular during this move? I don't mind touching it up afterwards in #1454.

Can you fix the merge conflicts so we can drop this in? #1454 touches a lot of the same files and I'd like to go on top this as opposed to the other way around.

@smarterclayton smarterclayton force-pushed the create_official_admin_command branch from b5e06f8 to 46b7509 Compare March 25, 2015 18:17
@smarterclayton
Copy link
Contributor Author

Fixed. remove-user-from-project is now remove-user (since it's under policy)

----- Original Message -----

@smarterclayton Can we fix those four in particular during this move? I
don't mind touching it up afterwards in
#1454.

Can you fix the merge conflicts so we can drop this in?
#1454 touches a lot of the same
files and I'd like to go on top this as opposed to the other way around.

Reply to this email directly or view it on GitHub:
#1446 (comment)

@deads2k
Copy link
Contributor

deads2k commented Mar 25, 2015

I'd swear that middle commit just got bigger....

[merge]

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_openshift3/1306/) (Image: devenv-fedora_1139)

@smarterclayton
Add an official 'openshift admin' command
ee70e7d 
Expose some of the experimental commands under it. Expose config
under both admin and cli.
@smarterclayton
Make overwrite-policy require confirmation
ac38ade
@smarterclayton smarterclayton force-pushed the create_official_admin_command branch from 46b7509 to ac38ade Compare March 26, 2015 13:58
@smarterclayton
Copy link
Contributor Author

[merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin up to ac38ade

openshift-bot pushed a commit that referenced this pull request Mar 26, 2015
Merge pull request #1446 from smarterclayton/create_official_admin_co…
2e784ee 
…mmand

Merged by openshift-bot
@openshift-bot openshift-bot merged commit 2e784ee into openshift:master Mar 26, 2015
@smarterclayton smarterclayton deleted the create_official_admin_command branch May 18, 2015 02:16
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Oct 23, 2017
Squashed 'cmd/service-catalog/go/src/github.com/kubernetes-incubator/…
4572a66 
…service-catalog/' changes from aa27078754..dabde2eb85

dabde2eb85 origin build: add origin tooling
b70c076 Reorder class and plan creation; test plan conflict handling (openshift#1459)
4bea012 Use versioned client APIs (openshift#1458)
ff4af30 clean up logic for 410 gone deprovision poll (openshift#1452)
3fddf27 clean up logic and fix message for failed poll (openshift#1451)
40926cd Fix typo from openshift#1354 (openshift#1456)
ff86ef2 Delete removed serviceplans when they have no instances left (openshift#1444)
8411a16 tweak binding setAndUpdateOrphanMitigation function (openshift#1448)
ce28252 Combine apiserver and controller-manager into a single service-catalog image (openshift#1343)
7bbc8ee Check service class / plan before allowing provisioning or plan changes. (openshift#1439)
baf28de Create listers before adding event handlers in controller (openshift#1446)
294157d remove setServiceBindingCondition dependency on controller (openshift#1441)
118a0f7 Fix typo in validation (openshift#1447)
117bfbd clean up error logging (openshift#1443)
dff470f Move "External" around in some resource names/properties (openshift#1354)
0885edb Adding expectedGot function and using it. (openshift#1440)
a7d582e Pretty controller broker (openshift#1442)
c5edfaf Set apimachinery build variables with semver info (openshift#1429)
0e90d82 Add a pretty formatter for ClusterService[Class|Plan] (openshift#1408)
fb874df Remove deprecated basic auth config support (openshift#1431)
f4cd181 Migrate to metav1 methods for manipulating controllerRefs (openshift#1433)
96b286e Make service/plan reference fields on instance spec selectable (openshift#1422)
33f2b04 First example using the pretty context builder. (openshift#1403)
7852917 Stop using corev1.ObjectReference and corev1.LocalObjectReference (openshift#1417)
fcf9480 Add tests for plan updates (openshift#1412)
819332e Add root CAs (openshift#1419)
b49a76a Clean Makefile a little (openshift#1399)
d681da0 Use a separate etcd prefix for each integration test to keep tests isolated (openshift#1415)
314a622 Wire etcd prefix to storage and call complete with options (openshift#1394)
REVERT: aa27078754 origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: dabde2eb859b5e31e97c01a704561fc27e1848b2
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Oct 24, 2017
Squashed 'cmd/service-catalog/go/src/github.com/kubernetes-incubator/…
ee4ff3f 
…service-catalog/' changes from aa27078754..510060232e

510060232e origin build: add origin tooling
de45e94 v0.1.0 chart changes (openshift#1468)
0bb9982 Modify Makefile to only specify ldflags once (openshift#1471)
5d6afac Fixes openshift#735: Add repo-sync script for charts (openshift#1453)
630f13f fix lingering unversioned client API (openshift#1466)
6f49128 Fix several logging errors (openshift#1464)
2aece61 Delete removed serviceClasses when they have no instances left (openshift#1450)
179d302 Uncommenting UID field after updating to k8s 1.8 (openshift#1457)
b70c076 Reorder class and plan creation; test plan conflict handling (openshift#1459)
4bea012 Use versioned client APIs (openshift#1458)
ff4af30 clean up logic for 410 gone deprovision poll (openshift#1452)
3fddf27 clean up logic and fix message for failed poll (openshift#1451)
40926cd Fix typo from openshift#1354 (openshift#1456)
ff86ef2 Delete removed serviceplans when they have no instances left (openshift#1444)
8411a16 tweak binding setAndUpdateOrphanMitigation function (openshift#1448)
ce28252 Combine apiserver and controller-manager into a single service-catalog image (openshift#1343)
7bbc8ee Check service class / plan before allowing provisioning or plan changes. (openshift#1439)
baf28de Create listers before adding event handlers in controller (openshift#1446)
294157d remove setServiceBindingCondition dependency on controller (openshift#1441)
118a0f7 Fix typo in validation (openshift#1447)
117bfbd clean up error logging (openshift#1443)
dff470f Move "External" around in some resource names/properties (openshift#1354)
0885edb Adding expectedGot function and using it. (openshift#1440)
a7d582e Pretty controller broker (openshift#1442)
c5edfaf Set apimachinery build variables with semver info (openshift#1429)
0e90d82 Add a pretty formatter for ClusterService[Class|Plan] (openshift#1408)
fb874df Remove deprecated basic auth config support (openshift#1431)
f4cd181 Migrate to metav1 methods for manipulating controllerRefs (openshift#1433)
96b286e Make service/plan reference fields on instance spec selectable (openshift#1422)
33f2b04 First example using the pretty context builder. (openshift#1403)
7852917 Stop using corev1.ObjectReference and corev1.LocalObjectReference (openshift#1417)
fcf9480 Add tests for plan updates (openshift#1412)
819332e Add root CAs (openshift#1419)
b49a76a Clean Makefile a little (openshift#1399)
d681da0 Use a separate etcd prefix for each integration test to keep tests isolated (openshift#1415)
314a622 Wire etcd prefix to storage and call complete with options (openshift#1394)
REVERT: aa27078754 origin build: add origin tooling

git-subtree-dir: cmd/service-catalog/go/src/github.com/kubernetes-incubator/service-catalog
git-subtree-split: 510060232e54eb64b294213bb5d7847e169a2fac
jpeeler pushed a commit to jpeeler/origin that referenced this pull request Feb 1, 2018
@pmorie
Create listers before adding event handlers in controller (openshift#…
baf28de 
…1446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smarterclayton @deads2k @openshift-bot