Skip to content

disconnect openapi aggregation #15528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jul 28, 2017

Fixes #15326

This does the minimal diff to disconnect the openapi aggregation to make future picks/fixes easier to bring back.

@liggitt @sttts @smarterclayton ptal.

@openshift-merge-robot openshift-merge-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 28, 2017
@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2017
@deads2k
Copy link
Contributor Author

deads2k commented Jul 28, 2017

hopefully this is a little faster.

@liggitt
Copy link
Contributor

liggitt commented Jul 28, 2017

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deads2k, liggitt

No associated issue. Update pull-request body to add a reference to an issue, or get approval with /approve no-issue

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor Author

deads2k commented Jul 28, 2017

This is expected to significantly decrease test-integration time. Bumping to the top of the queue.

@liggitt
Copy link
Contributor

liggitt commented Jul 28, 2017

took 20 minutes off the time

@smarterclayton
Copy link
Contributor

You'll like this.

Before: one integration test took about 40 wall seconds and about 38 core seconds.
After: one integration test took about 20 wall seconds and 0.8 core seconds

@smarterclayton
Copy link
Contributor

Of the remaining 0.8 core seconds.... 0.6 core seconds are directly attributable to openapi parsing on startup.

@deads2k
Copy link
Contributor Author

deads2k commented Jul 28, 2017

Before: one integration test took about 40 wall seconds and about 38 core seconds.
After: one integration test took about 20 wall seconds and 0.8 core seconds

But lacked sufficient imagination. It's taking me something like six seconds to have openapi start even with this pull. I think this should still go in, but I'll keep chasing it. We don't need openapi for integration tests.

@sttts
Copy link
Contributor

sttts commented Jul 28, 2017

Hou, what a difference. What made it that slow?

@deads2k
Copy link
Contributor Author

deads2k commented Jul 28, 2017

I don't see any swagger changes between the test and now. letting it through without a retest

@smarterclayton
Copy link
Contributor

I think I might have found the 20 characters that make all of this go away :)

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue

@openshift-merge-robot openshift-merge-robot merged commit 6f4c876 into openshift:master Jul 28, 2017
@deads2k deads2k deleted the agg-14-disconnectopenapi branch August 3, 2017 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. queue/critical-fix retest-not-required size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1.7 allocates an enormous amount of space from regex
7 participants