-
Notifications
You must be signed in to change notification settings - Fork 4.7k
disconnect openapi aggregation #15528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disconnect openapi aggregation #15528
Conversation
hopefully this is a little faster. |
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deads2k, liggitt No associated issue. Update pull-request body to add a reference to an issue, or get approval with The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
This is expected to significantly decrease test-integration time. Bumping to the top of the queue. |
took 20 minutes off the time |
You'll like this. Before: one integration test took about 40 wall seconds and about 38 core seconds. |
Of the remaining 0.8 core seconds.... 0.6 core seconds are directly attributable to openapi parsing on startup. |
But lacked sufficient imagination. It's taking me something like six seconds to have openapi start even with this pull. I think this should still go in, but I'll keep chasing it. We don't need openapi for integration tests. |
Hou, what a difference. What made it that slow? |
I don't see any swagger changes between the test and now. letting it through without a retest |
I think I might have found the 20 characters that make all of this go away :) |
Automatic merge from submit-queue |
Fixes #15326
This does the minimal diff to disconnect the openapi aggregation to make future picks/fixes easier to bring back.
@liggitt @sttts @smarterclayton ptal.