convert wolfssl to a git submodule #887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llange
force-pushed
the
convert-wolfssl-submodule
branch
from
0a515bf to
8f68e11
Compare
|
Steps: B) Then I can update this very PR with the tip of the (patched) 4.7.0 branch ✅ C) Then I'll remove the |
llange
force-pushed
the
convert-wolfssl-submodule
branch
from
8f68e11 to
a69eceb
Compare
|
Review and merge is now possible. |
neomilium
approved these changes
May 12, 2023
|
It was easy to review code but hard to know if it works as expected. I rely on @llange 's own build and tests. |
llange
force-pushed
the
convert-wolfssl-submodule
branch
from
a69eceb to
ff8d2ee
Compare
|
This seems ok to me. Apart from some parts of it used by wolfssh, we don't seem to use this module at all. So long as ssh connections can still be established to the box, I think this is ok. |
markwj
approved these changes
May 16, 2023
wolfssl has been forked (https://github.com/openvehicles/wolfssl) and the subdirectory converted to a Git submodule. Additionally, it has been put one directory level below (in vehicle/OVMS.V3/components/wolfssl/wolfssl) to better separate the upstream code from our build glue (component.mk, CMakeLists.txt and configuration files) This way it's easier to track any changes made to the module, upgrade when upstram changes, or propose patches to upstream. We kept the existing version (v4.7.0-stable) - it will be upgraded later Signed-off-by: Ludovic LANGE <[email protected]>
llange
force-pushed
the
convert-wolfssl-submodule
branch
from
ff8d2ee to
cb5f1c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wolfssl has been forked (https://github.com/openvehicles/wolfssl) and the subdirectory converted to a Git submodule.
Additionally, it has been put one directory level below (in vehicle/OVMS.V3/components/wolfssl/wolfssl) to better separate the upstream code from our build glue (component.mk, CMakeLists.txt and configuration files)
This way it's easier to track any changes made to the module, upgrade when upstram changes, or propose patches to upstream.
We kept the existing version (v4.7.0-stable) - it will be upgraded later