Skip to content

feat: retrieve ConfigurationService from ConfigurationServiceProvider #1010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Mar 11, 2022
Merged

feat: retrieve ConfigurationService from ConfigurationServiceProvider #1010

merged 19 commits into from
Mar 11, 2022

Conversation

metacosm
Copy link
Collaborator

@metacosm metacosm commented Mar 9, 2022 •
edited
Loading

Depends on #1013

@metacosm metacosm self-assigned this Mar 9, 2022
@metacosm metacosm requested a review from csviri March 9, 2022 12:42
@metacosm metacosm force-pushed the static-configuration-service branch 6 times, most recently from 6a5a3e3 to c33cdd1 Compare March 11, 2022 09:34
@metacosm metacosm marked this pull request as ready for review March 11, 2022 09:50
metacosm added 16 commits March 11, 2022 14:21
@metacosm
feat: retrieve ConfigurationService from ConfigurationServiceProvider
aa9d3c2
@metacosm
feat: make it possible to reset ConfigurationServiceProvider
c0a8064
@metacosm
feat: provide a default default :)
f7d1d42
@metacosm
fix: tests
fc9093c
@metacosm
feat: start using ConfigurationServiceProvider
255d7f3
@metacosm
fix: remove now unneeded loading of DefaultConfigurationService
d27c76f
@metacosm
refactor: make it easier to debug things
dad795e
@metacosm
refactor: remove ConfigurationService from ResourceConfiguration
49a19dd
@metacosm
fix: lambda form doesn't record parameter type
056f80d
@metacosm
fix: configure and properly reset ConfigurationServiceProvider
23cb8de
@metacosm
fix: suppliers were improperly defined
5ebf42e
@metacosm
fix: properly override ConfigurationService for the test and reset after
bd720d9
@metacosm
feat: improve ConfigurationServiceProvider implementation, add tests
9f22a06
@metacosm
fix: format
6c22407
@metacosm
fix: Operator should only set ConfigurationService, not hold onto it
635f491
@metacosm
fix: more ConfigurationService holding removal
b44086e
@csviri
Copy link
Collaborator

csviri commented Mar 11, 2022

Does this help with quarkus extension too? or the point is just to have a global config serivce?

csviri
csviri approved these changes Mar 11, 2022
View reviewed changes
Copy link
Collaborator

@csviri csviri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM , just 1 minor comment

@metacosm
fix: make sure that ConfigurationServiceProvider is reset
40d9124 
If we decide to go along with this work, we will probably need a JUnit
extension to always reset the ConfigurationServiceProvider before and
after each test automatically.
@metacosm
Copy link
Collaborator Author

Does this help with quarkus extension too? or the point is just to have a global config serivce?

I'm not sure yet… It started with the idea that it would help but I need to try it out…

@metacosm metacosm force-pushed the static-configuration-service branch from f283b06 to aadba2b Compare March 11, 2022 13:44
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 62 Code Smells

38.7% 38.7% Coverage
0.0% 0.0% Duplication

@metacosm metacosm merged commit 13a6c83 into next Mar 11, 2022
@metacosm metacosm deleted the static-configuration-service branch March 11, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csviri csviri csviri approved these changes

Assignees

@metacosm metacosm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@metacosm @csviri