[issue-687] Refactor/operator register api #688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csviri
reviewed
Nov 18, 2021
| controllers.add(controller); | ||
|
|
||
| final var watchedNS = | ||
| configuration.watchAllNamespaces() ? "[all namespaces]" : configuration.getEffectiveNamespaces(); |
There was a problem hiding this comment.
This line does not seems to be formatted if you just build the project with maven it should fix it.
There was a problem hiding this comment.
Thanks for the reply :)
I rebuild maven and made a commit by modifying the code formats.
|
Just made a minor not, otherwise LGTM!! Thank you! |
csviri
approved these changes
Nov 18, 2021
metacosm
requested changes
Nov 19, 2021
operator-framework-core/src/test/java/io/javaoperatorsdk/operator/OperatorTest.java
Show resolved
Hide resolved
|
As #678 was merged into the base branch |
Conflict has been corrected and rebase has been completed with v2. :) |
heesuk-ahn
force-pushed
the
refactor/operator-register-api
branch
from
97deb5f to
c0b9ef2
Compare
metacosm
approved these changes
Nov 22, 2021
…to `kubernetesClient.getKubernetesVersion()`
heesuk-ahn
force-pushed
the
refactor/operator-register-api
branch
from
c0b9ef2 to
eb7a56b
Compare
|
thank you @heesuk-ahn ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal
by #687