-
Notifications
You must be signed in to change notification settings - Fork 219
[issue-687] Refactor/operator register api #688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
csviri
merged 6 commits into
operator-framework:v2
from
heesuk-ahn:refactor/operator-register-api
Nov 23, 2021
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bfbfae0
test: added `OperatorTest` for register api
heesuk-ahn a131eb7
refactor: refactored `Operator.register` api
heesuk-ahn 2f49370
refactor: modified deprecated `kubernetesClient.getVersion()` method …
heesuk-ahn e7c4f91
style: fixed code format by maven build
heesuk-ahn eb7a56b
test: added code to check controller is registered
heesuk-ahn 98d21c7
test: modify to use `noUpdate` api
heesuk-ahn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
79 changes: 79 additions & 0 deletions
79
operator-framework-core/src/test/java/io/javaoperatorsdk/operator/OperatorTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,79 @@ | ||
package io.javaoperatorsdk.operator; | ||
|
||
import org.junit.jupiter.api.Assertions; | ||
import org.junit.jupiter.api.DisplayName; | ||
import org.junit.jupiter.api.Test; | ||
|
||
import io.fabric8.kubernetes.client.CustomResource; | ||
import io.fabric8.kubernetes.client.KubernetesClient; | ||
import io.javaoperatorsdk.operator.api.config.ConfigurationService; | ||
import io.javaoperatorsdk.operator.api.config.ControllerConfiguration; | ||
import io.javaoperatorsdk.operator.api.reconciler.Context; | ||
import io.javaoperatorsdk.operator.api.reconciler.Reconciler; | ||
import io.javaoperatorsdk.operator.api.reconciler.UpdateControl; | ||
|
||
import static org.assertj.core.api.AssertionsForClassTypes.assertThat; | ||
import static org.mockito.Mockito.mock; | ||
import static org.mockito.Mockito.verify; | ||
import static org.mockito.Mockito.when; | ||
|
||
class OperatorTest { | ||
|
||
private final KubernetesClient kubernetesClient = mock(KubernetesClient.class); | ||
private final ConfigurationService configurationService = mock(ConfigurationService.class); | ||
private final ControllerConfiguration configuration = mock(ControllerConfiguration.class); | ||
|
||
private final Operator operator = new Operator(kubernetesClient, configurationService); | ||
private final FooReconciler fooReconciler = FooReconciler.create(); | ||
|
||
@Test | ||
@DisplayName("should register `Reconciler` to Controller") | ||
public void shouldRegisterReconcilerToController() { | ||
// given | ||
when(configurationService.getConfigurationFor(fooReconciler)).thenReturn(configuration); | ||
when(configuration.watchAllNamespaces()).thenReturn(true); | ||
when(configuration.getName()).thenReturn("FOO"); | ||
when(configuration.getResourceClass()).thenReturn(FooReconciler.class); | ||
|
||
// when | ||
operator.register(fooReconciler); | ||
|
||
// then | ||
verify(configuration).watchAllNamespaces(); | ||
verify(configuration).getName(); | ||
verify(configuration).getResourceClass(); | ||
|
||
assertThat(operator.getControllers().size()).isEqualTo(1); | ||
assertThat(operator.getControllers().get(0).getReconciler()).isEqualTo(fooReconciler); | ||
} | ||
|
||
@Test | ||
@DisplayName("should throw `OperationException` when Configuration is null") | ||
public void shouldThrowOperatorExceptionWhenConfigurationIsNull() { | ||
Assertions.assertThrows(OperatorException.class, () -> operator.register(fooReconciler, null)); | ||
} | ||
|
||
private static class FooCustomResource extends CustomResource<FooSpec, FooStatus> { | ||
} | ||
|
||
private static class FooSpec { | ||
} | ||
|
||
private static class FooStatus { | ||
} | ||
|
||
private static class FooReconciler implements Reconciler<FooCustomResource> { | ||
|
||
private FooReconciler() {} | ||
|
||
public static FooReconciler create() { | ||
return new FooReconciler(); | ||
} | ||
|
||
@Override | ||
public UpdateControl<FooCustomResource> reconcile(FooCustomResource resource, Context context) { | ||
return UpdateControl.noUpdate(); | ||
} | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.