Skip to content

chore: webpack example #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

chore: webpack example #458

wants to merge 2 commits into from

Conversation

zhangmo8
Copy link

@zhangmo8 zhangmo8 commented Jul 29, 2024 •
edited
Loading

Sorry, I really don't know what type of commit to use
Create this PR to increase the webpack case.

close #163 .

@socket-security Socket Security
Copy link

socket-security bot commented Jul 31, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

View full report↗︎

@socket-security Socket Security
Copy link

socket-security bot commented Jul 31, 2024 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@posva
Copy link
Owner

posva commented Jul 31, 2024

Thanks for the contribution! You should probably rebase against main and run pnpm i to fix any pnpm-lock conflicts

@zhangmo8 zhangmo8 closed this Aug 1, 2024
@zhangmo8 zhangmo8 reopened this Aug 1, 2024
@zhangmo8 zhangmo8 marked this pull request as draft August 1, 2024 03:36
@zhangmo8
Copy link
Author

zhangmo8 commented Aug 1, 2024

When I updated the code,It seems that some unexpected mistakes have occurred, It seems to be a problem with [id].vue and loader, and I may need to pay more attention to this.

image

@zhangmo8 zhangmo8 marked this pull request as ready for review August 1, 2024 05:45
@zhangmo8
Copy link
Author

zhangmo8 commented Aug 1, 2024 •
edited
Loading

When I updated the code,It seems that some unexpected mistakes have occurred, It seems to be a problem with [id].vue and loader, and I may need to pay more attention to this.

image

This problem occurs when both setup script and [xx] routing are used together, but option setup is fine.

If anyone wants to use both of these things in webpack or vue-cli, please install unplugin-vue2-script-setup at the same time

@codecov Codecov
Copy link

codecov bot commented Aug 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.15%. Comparing base (c3297e4) to head (40db067).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #458   +/-   ##
=======================================
  Coverage   66.15%   66.15%           
=======================================
  Files          37       37           
  Lines        3088     3088           
  Branches      593      593           
=======================================
  Hits         2043     2043           
  Misses       1035     1035           
  Partials       10       10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

posva
posva reviewed Aug 2, 2024
View reviewed changes
posva
posva reviewed Aug 5, 2024
View reviewed changes
zhangmo8 and others added 2 commits August 5, 2024 17:55
@zhangmo8
# This is a combination of 7 commits.
9668fbb 
# This is the 1st commit message:

chore: resolve conflicts

# This is the commit message posva#2:

fix: fix the vue-loader error

# This is the commit message posva#3:

fix: setup return route

# This is the commit message posva#4:

fix: lint fix

# This is the commit message posva#5:

Update examples/webpack/shims-vue.d.ts

Co-authored-by: Eduardo San Martin Morote <[email protected]>
# This is the commit message posva#6:

chore: update webpack deps & lock file

# This is the commit message posva#7:

chore: update webpack deps & lock file
chore: update lock file
f06d227
@zhangmo8
Copy link
Author

zhangmo8 commented Aug 5, 2024

Sorry, I accidentally pushed a commit using my work mailbox, so I merged these commits. [Facepalm]

@zhangmo8 zhangmo8 closed this Aug 16, 2024
@zhangmo8
Copy link
Author

Will reactor a PR for this

@zhangmo8 zhangmo8 mentioned this pull request Aug 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@posva posva posva left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

definePage doesn't work with webpack
2 participants
@zhangmo8 @posva