[DOC] Fixed Contributions broken link #759
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #759 +/- ##
=======================================
Coverage 94.49% 94.49%
=======================================
Files 17 17
Lines 745 745
=======================================
Hits 704 704
Misses 41 41 |
samukweku
approved these changes
Oct 7, 2020
ericmjl
requested changes
Oct 8, 2020
There was a problem hiding this comment.
Hi @Bhavna777! Thanks for your contribution. Only one requested change, and we’re good to go.
| @@ -8,7 +8,7 @@ Every little bit helps, and credit will always be given. | |||
| The following sections detail a variety of ways to contribute, | |||
| as well as how to get started. | |||
|
|
|||
| .. note:: Please take a look at the `types of Contributions <CONTRIBUTION_TYPES.html>`__ that we welcome, | |||
| .. note:: Please take a look at the `types of Contributions <https://ericmjl.github.io/pyjanitor/CONTRIBUTION_TYPES.html>`__ that we welcome, | |||
There was a problem hiding this comment.
Could you change this to a sphinx-style relative link?
https://www.sphinx-doc.org/en/master/usage/restructuredtext/roles.html#ref-role
This will make the link agnostic of whether the docs are deployed on RTD or GH Pages.
ericmjl
changed the title
|
Hi @Bhavna777! Thanks for helping out during Hacktoberfest! Feel free to update the |
|
Closing in favor of #839 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #744