Skip to content

[DOC] Updated broken links in the README and contributing docs files #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 18, 2021

Conversation

nvamsikrishna05
Copy link
Collaborator

@nvamsikrishna05 nvamsikrishna05 commented Jul 11, 2021

PR Description

Please describe the changes proposed in the pull request:

  • Updated the Broken Links in the README and Contributing doc files.

**This PR resolves #817 **

PR Checklist

Please ensure that you have done the following:

  1. PR in from a fork off your branch. Do not PR from <your_username>:dev, but rather from <your_username>:<feature-branch_name>.
  1. If you're not on the contributors list, add yourself to AUTHORS.rst.
  1. Add a line to CHANGELOG.md under the latest version header (i.e. the one that is "on deck") describing the contribution.
    • Do use some discretion here; if there are multiple PRs that are related, keep them in a single line.

Automatic checks

There will be automatic checks run on the PR. These include:

  • Building a preview of the docs on Netlify
  • Automatically linting the code
  • Making sure the code is documented
  • Making sure that all tests are passed
  • Making sure that code coverage doesn't go down.

Relevant Reviewers

Please tag maintainers to review.

@samukweku
Copy link
Collaborator

@nvamsikrishna05 have a look at the notebook and kindly resolve it, using the same idea as your other PR

@nvamsikrishna05
Copy link
Collaborator Author

@samukweku It's the same issue as other PR, so I am waiting for that PR to merge and will update this after that.

@ericmjl
Copy link
Member

ericmjl commented Jul 12, 2021

@nvamsikrishna05 we're good to merge in the latest dev branch! Can you do that? I'll be able to do a reviw shortly. 😄

@nvamsikrishna05
Copy link
Collaborator Author

@ericmjl Updated the PR. you can review it now. Thanks.

Copy link
Member

@loganthomas loganthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @nvamsikrishna05!

@ericmjl
Copy link
Member

ericmjl commented Jul 18, 2021

With @samukweku and @loganthomas both finishing the review, I'm good to go too.

@ericmjl ericmjl merged commit 03a51a9 into pyjanitor-devs:dev Jul 18, 2021
@ericmjl
Copy link
Member

ericmjl commented Jul 18, 2021

Thanks @nvamsikrishna05!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Update broken links after PyJanitor Dev migration
4 participants