-
Notifications
You must be signed in to change notification settings - Fork 173
[ENH] Categoricals improve #930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…h a for loop; use hypothesis for tests
Codecov Report
@@ Coverage Diff @@
## dev #930 +/- ##
==========================================
+ Coverage 95.95% 95.96% +0.01%
==========================================
Files 19 19
Lines 2545 2530 -15
==========================================
- Hits 2442 2428 -14
+ Misses 103 102 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a big PR and I was reviewing it at 11 pm at night. My review is necessarily not going to be complete.
I think we should get another pair of eyes on this PR before merging.
Co-authored-by: Eric Ma <[email protected]>
…egoricals_improve
…yjanitor into categoricals_improve
…egoricals_improve
…egoricals_improve
…egoricals_improve
@ericmjl @loganthomas made the edits .... ready for your review |
It's been reviewed by two people, so I'm going to merge! |
PR Description
Please describe the changes proposed in the pull request:
As_Categorical
helper functioncopy
of the DataFrame at the start of the functiondf = df.copy()
This PR resolves #927.
PR Checklist
Please ensure that you have done the following:
<your_username>
:dev
, but rather from<your_username>
:<feature-branch_name>
.AUTHORS.rst
.CHANGELOG.md
under the latest version header (i.e. the one that is "on deck") describing the contribution.Automatic checks
There will be automatic checks run on the PR. These include:
Relevant Reviewers
Please tag maintainers to review.