Skip to content

empty-comment line number bug fix #4010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

orSolocate
Copy link
Contributor

Steps

  • Add yourself to CONTRIBUTORS if you are a new contributor.
  • Add a ChangeLog entry describing what your PR does.
  • If it's a new feature or an important bug fix, add a What's New entry in doc/whatsnew/<current release.rst>.
  • Write a good description on what the PR does.

Description

Fixed empty-comment wrong line number in its message. Was 1 line behind the actual line number.
Fixed implementation and unittest.

Type of Changes

Type
🐛 Bug fix
✨ New feature
🔨 Refactoring
📜 Docs

Related Issue

#4009

@coveralls
Copy link

coveralls commented Jan 2, 2021

Coverage Status

Coverage remained the same at 90.681% when pulling 5b109b4 on orSolocate:empty_comment_bug_fix into b41e8d9 on PyCQA:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 90.673% when pulling 5b109b4 on orSolocate:empty_comment_bug_fix into b41e8d9 on PyCQA:master.

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix, it seems pretty straightforward. Could you just add a functional test in tests/functional/e/empty_comment.py, please ?

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, sorry, what I asked for is impossible as functional test need non empty comments to work.

@Pierre-Sassoulas Pierre-Sassoulas linked an issue Jan 3, 2021 that may be closed by this pull request
@Pierre-Sassoulas Pierre-Sassoulas merged commit 60e2848 into pylint-dev:master Jan 3, 2021
@Pierre-Sassoulas
Copy link
Member

I merged it, your change will be available when we release 2.6.1 or 2.7.0 (soon!) :) ! Congrats on becoming a pylint's contributor !

@orSolocate
Copy link
Contributor Author

@Pierre-Sassoulas Thanks for accepting it. Hopefully more contributions will follow :)

@orSolocate orSolocate deleted the empty_comment_bug_fix branch February 2, 2021 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong line number for empty-comment message
3 participants