Skip to content

slurmint: made the script more robust to different system configurations #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

d4l3k
Copy link
Member

@d4l3k d4l3k commented Jun 13, 2022

This updates the slurmint script to be more robust to environment changes since we switched to a new slurm cluster.

It removes the hardcoded /home/ubuntu and uses venv provided by miniconda so we don't need virtualenv installed on the host.

See https://www.internalfb.com/intern/wiki/PyTorch_R2P/Development/Slurm/ for more information

Test plan:

env SLURM_INSTANCE_MASTER=... scripts/slurmint.sh

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 13, 2022
@facebook-github-bot
Copy link
Contributor

@d4l3k has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #516 (fd9b1e2) into main (42e9b44) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #516   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files          65       65           
  Lines        3932     3932           
=======================================
  Hits         3727     3727           
  Misses        205      205           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42e9b44...fd9b1e2. Read the comment docs.

@d4l3k d4l3k deleted the slurmintfix branch October 28, 2022 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants