Skip to content

Add drawer to display image data #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 20, 2023
Merged

Add drawer to display image data #118

merged 6 commits into from
Jun 20, 2023

Conversation

F-X64
Copy link
Member

@F-X64 F-X64 commented Jun 19, 2023

Add drawer element to image table
Add tabs to separate CLI command and image details
Add missing copy command to image ID

Screencast.from.2023-06-19.18-04-11.webm

Closes #97

F-X64 added 5 commits June 19, 2023 09:29
Add new DetailsDrawer component
Add drawer layout to ImageTable
Add close on page change
Add close on search
@F-X64 F-X64 requested review from major, epapbak and miyunari June 19, 2023 16:12
@miyunari
Copy link
Member

Nice work! 👍 Is the element now big enough for the google image details or is there still a scroll bar necessary? :)

@F-X64
Copy link
Member Author

F-X64 commented Jun 20, 2023

Nice work! +1 Is the element now big enough for the google image details or is there still a scroll bar necessary? :)

Haha thanks! Yeah it's big enough (well it depends on your screensize. I doubt it'll look good on mobile yet)
I debate if we should truncate the google imageID though, it's simply too long.. with the added copy button we don't technically need to display the full string to make it available.

Copy link
Member

@major major left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea what this code is doing but your video looks fantastic.

@major major merged commit ffcc3b5 into main Jun 20, 2023
@major major deleted the add-imae-data-drawer#97 branch June 20, 2023 19:05
@F-X64 F-X64 added the v2 Second iteration of the CID front-end label Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2 Second iteration of the CID front-end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add image detail information modal to data table
3 participants