-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: support updateLockFiles
for all managers
#35993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
reduckted
wants to merge
28
commits into
renovatebot:main
Choose a base branch
from
reduckted:feature/33118-skip-artifact-updating
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: support updateLockFiles
for all managers
#35993
reduckted
wants to merge
28
commits into
renovatebot:main
from
reduckted:feature/33118-skip-artifact-updating
+395
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduckted
commented
May 17, 2025
viceice
reviewed
May 17, 2025
viceice
reviewed
May 21, 2025
rarkins
requested changes
May 24, 2025
viceice
previously approved these changes
May 25, 2025
Co-authored-by: RahulGautamSingh <[email protected]>
Co-authored-by: RahulGautamSingh <[email protected]>
skipArtifactUpdating
updateLockFiles
for all managers
RahulGautamSingh
approved these changes
May 27, 2025
viceice
reviewed
May 27, 2025
@@ -982,7 +982,6 @@ const options: RenovateOptions[] = [ | |||
description: 'Set to `false` to disable lock file updating.', | |||
type: 'boolean', | |||
default: true, | |||
supportedManagers: ['npm'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should maintain a list which managers support lockfiles in general
Co-authored-by: Michael Kriese <[email protected]>
This reverts commit 656fa4b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This changes the existing
updateLockFiles
option to apply to all managers. Previously that option only applied to the npm manager.Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: