feat: support updateLockFiles for all managers

docs/usage/configuration-options.md

@@ -4391,6 +4391,13 @@ To opt in to letting Renovate update internal package versions normally, set thi
 
 ## updateLockFiles
 
+Set this to false when automatic lock file updating fails, is incorrect, or not needed.
+When this option is set to false, Renovate won't attempt to update lock files, so you will need to update them yourself, either manually or through secondary automation such as CI workflows.
+
+<!-- prettier-ignore -->
+!!! note
+    When this option is used in package rules, along with grouped upgrades, lock file updating will only be disabled if every upgrade in the grouped branch wants to disable it.
+
 ## updateNotScheduled
 
 When schedules are in use, it generally means "no updates".

lib/config/options/index.ts

@@ -982,7 +982,6 @@ const options: RenovateOptions[] = [
     description: 'Set to `false` to disable lock file updating.',
     type: 'boolean',
     default: true,
-    supportedManagers: ['npm'],
   },
   {
     name: 'skipInstalls',

lib/config/types.ts

@@ -97,6 +97,7 @@ export interface RenovateSharedConfig {
   suppressNotifications?: string[];
   timezone?: string;
   unicodeEmoji?: boolean;
+  updateLockFiles?: boolean;
 }
 
 // Config options used only within the global worker

lib/modules/manager/npm/post-update/index.spec.ts

@@ -559,6 +559,36 @@ describe('modules/manager/npm/post-update/index', () => {
       });
     });
 
+    it('skip lock file updating', async () => {
+      expect(
+        await getAdditionalFiles(
+          {
+            ...updateConfig,
+            updateLockFiles: false,
+            reuseExistingBranch: true,
+            upgrades: [
+              {
+                depName: 'postcss',
+                isRemediation: true,
+                managerData: {
+                  npmLock: 'package-lock.json',
+                },
+                rangeStrategy: 'widen',
+              },
+            ],
+          },
+          additionalFiles,
+        ),
+      ).toStrictEqual({
+        artifactErrors: [],
+        updatedArtifacts: [],
+      });
+      expect(spyNpm).not.toHaveBeenCalled();
+      expect(logger.logger.debug).toHaveBeenCalledWith(
+        'Skipping lock file generation',
+      );
+    });
+
     it('reuse existing up-to-date', async () => {
       expect(
         await getAdditionalFiles(

lib/modules/manager/types.ts

@@ -45,6 +45,7 @@ export interface UpdateArtifactsConfig {
   newVersion?: string;
   newMajor?: number;
   registryAliases?: Record<string, string>;
+  updateLockFiles?: boolean;
   lockFiles?: string[];
 }
 

lib/workers/repository/update/branch/get-updated.spec.ts

@@ -713,6 +713,147 @@ describe('workers/repository/update/branch/get-updated', () => {
       });
     });
 
+    it('does not update artifacts when updateLockFiles=false', async () => {
+      const branchName = 'renovate/wheel-0.x';
+      const updateType = 'patch';
+      const lockedVersion = '0.45.0';
+      const newVersion = '0.45.1';
+      const currentValue = '==0.45.0';
+      const newRegexValue = newVersion;
+      const newValue = '==0.45.1';
+
+      const packageFile = 'requirements.in';
+      const lockFile = 'requirements.txt';
+
+      const regexWheelLookup: LookupUpdate = {
+        newVersion,
+        newValue: newRegexValue,
+        updateType,
+        branchName,
+      };
+
+      const pipCompileWheelLookup: LookupUpdate = {
+        ...regexWheelLookup,
+        newValue,
+      };
+      const pipCompileWheelDep = {
+        currentValue,
+        lockedVersion,
+        updates: [pipCompileWheelLookup],
+      };
+
+      config.manager = 'pip-compile';
+      config.branchName = branchName;
+      config.updateLockFiles = false;
+      config.upgrades.push({
+        packageFile,
+        lockFiles: [lockFile],
+        manager: 'pip-compile',
+        updateType,
+        depName: 'alpha',
+        currentValue,
+        newVersion,
+        branchName,
+      });
+      config.upgrades.push({
+        packageFile,
+        lockFiles: [lockFile],
+        manager: 'pip-compile',
+        updateType,
+        depName: 'beta',
+        currentValue,
+        newVersion,
+        branchName,
+      });
+
+      config.packageFiles = {
+        'pip-compile': [
+          {
+            packageFile,
+            lockFiles: [lockFile],
+            deps: [pipCompileWheelDep],
+          },
+        ],
+      };
+
+      pipCompile.updateArtifacts.mockResolvedValue([]);
+      autoReplace.doAutoReplace.mockResolvedValue('new content');
+
+      await getUpdatedPackageFiles(config);
+
+      expect(pipCompile.updateArtifacts).not.toHaveBeenCalled();
+    });
+
+    it('updates artifacts when updateLockFiles=true', async () => {
+      const branchName = 'renovate/wheel-0.x';
+      const updateType = 'patch';
+      const lockedVersion = '0.45.0';
+      const newVersion = '0.45.1';
+      const currentValue = '==0.45.0';
+      const newRegexValue = newVersion;
+      const newValue = '==0.45.1';
+
+      const packageFile = 'requirements.in';
+      const lockFile = 'requirements.txt';
+
+      const regexWheelLookup: LookupUpdate = {
+        newVersion,
+        newValue: newRegexValue,
+        updateType,
+        branchName,
+      };
+
+      const pipCompileWheelLookup: LookupUpdate = {
+        ...regexWheelLookup,
+        newValue,
+      };
+      const pipCompileWheelDep = {
+        currentValue,
+        lockedVersion,
+        updates: [pipCompileWheelLookup],
+      };
+
+      config.manager = 'pip-compile';
+      config.branchName = branchName;
+      config.upgrades.push({
+        packageFile,
+        lockFiles: [lockFile],
+        manager: 'pip-compile',
+        updateType,
+        depName: 'alpha',
+        currentValue,
+        newVersion,
+        branchName,
+      });
+      config.upgrades.push({
+        packageFile,
+        lockFiles: [lockFile],
+        manager: 'pip-compile',
+        updateType,
+        depName: 'beta',
+        currentValue,
+        newVersion,
+        branchName,
+      });
+
+      config.packageFiles = {
+        'pip-compile': [
+          {
+            packageFile,
+            lockFiles: [lockFile],
+            deps: [pipCompileWheelDep],
+          },
+        ],
+      };
+
+      pipCompile.updateArtifacts.mockResolvedValue([]);
+      autoReplace.doAutoReplace.mockResolvedValue('new content');
+
+      await getUpdatedPackageFiles(config);
+
+      expect(pipCompile.updateArtifacts).toHaveBeenCalledTimes(1);
+    });
+
     it('attempts updateLockedDependency and handles unsupported', async () => {
       config.upgrades.push({
         packageFile: 'package.json',

lib/workers/repository/update/branch/get-updated.ts

@@ -474,7 +474,14 @@ async function managerUpdateArtifacts(
 ): Promise<UpdateArtifactsResult[] | null> {
   const updateArtifacts = get(manager, 'updateArtifacts');
   if (updateArtifacts) {
-    return await updateArtifacts(updateArtifact);
+    if (updateArtifact.config.updateLockFiles === false) {
+      logger.debug(
+        { manager, packageFileName: updateArtifact.packageFileName },
+        'Skipping artifact update',
+      );
+    } else {
+      return await updateArtifacts(updateArtifact);
+    }
   }
   return null;
 }

lib/workers/repository/updates/__snapshots__/generate.spec.ts.snap

@@ -28,6 +28,7 @@ exports[`workers/repository/updates/generate > generateBranchConfig() > handles
   "recreateClosed": false,
   "releaseTimestamp": undefined,
   "skipInstalls": true,
+  "updateLockFiles": true,
   "upgrades": [
     {
       "branchName": "some-branch",
@@ -118,6 +119,7 @@ exports[`workers/repository/updates/generate > generateBranchConfig() > handles
   "recreateClosed": false,
   "releaseTimestamp": undefined,
   "skipInstalls": true,
+  "updateLockFiles": true,
   "upgrades": [
     {
       "branchName": "some-branch",
@@ -198,6 +200,7 @@ exports[`workers/repository/updates/generate > generateBranchConfig() > handles
   "recreateClosed": true,
   "releaseTimestamp": undefined,
   "skipInstalls": true,
+  "updateLockFiles": true,
   "upgrades": [
     {
       "branchName": "some-branch",
@@ -245,6 +248,7 @@ exports[`workers/repository/updates/generate > generateBranchConfig() > handles
   "recreateClosed": false,
   "releaseTimestamp": undefined,
   "skipInstalls": true,
+  "updateLockFiles": true,
   "upgrades": [
     {
       "branchName": "some-branch",