V0.2.0 review updates #46
Conversation
for more information, see https://pre-commit.ci
…convention and formatting changes
…d update step names
…r current convention
… a pull request is raised since a push will always run
| - run: pip install mkdocs-material | ||
| - run: mkdocs gh-deploy --force | ||
| - name: Install mkdocs-material | ||
| run: pip install mkdocs-material |
There was a problem hiding this comment.
we should consider using a golang alternative for mkdocs as its sad a golang template repo needs python 😄
There was a problem hiding this comment.
Can you make a fresh issue for this @mridulganga, we went for anything that we were able to get working.
Now, would be a good time to start working on evaluating and taking out non-golang bits.
for more information, see https://pre-commit.ci
|
Thanks, @haani-niyaz and @mridulganga for the help. |
@shukra-in-spirit, I was planning on merging #45 to this PR as it completes the
Do you mean with the I also think some release planning is in order to keep everyone on the same page. |
|
Yeap. With a fix mention in the comment to bump up the x in v0.1.x |
@shukra-in-spirit, I don't see any commits with |
…ritical information #52
for more information, see https://pre-commit.ci
fix(Dockerfile): Go image update What does this commit do? ========================= * Use alpine Go base image to reduce size * Reuse make command to build binary Why are we doing this? ====================== * Shrink image size to increase build times * Reuse make to provide a single place add binary build updates
…repos using the template The same project is being used by all repos using the template. To fix this the project needs to be created in advance and this is also a pre-requisite as per https://github.com/SonarSource/sonarcloud-github-action#requirements. This should be automated as part of the workflow. Otherwise, it becomes a bottleneck for teams trying to onboard and waiting for admins to create the project.
|
🎉 This issue has been resolved in version 0.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Change Summary
Docs update
Closes #44
Limit builds
on:pull_requestsinceon:pushresults are available in the PR and this will avoid duplicate runsAddresses #43
Dockerfile enhancements
Closes #45 .