Skip to content

fix(sonarcloud): Descoped and properties file should be removed #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 28, 2022

Conversation

haani-niyaz
Copy link
Collaborator

@haani-niyaz haani-niyaz commented Jul 26, 2022

Description

SonarCloud was descoped in #46. Remove the sonar-project.properties file.

Fixes #46

Additionally, formats the README file.

Current status

  • Waiting for review
  • Waiting for comment resolution
  • Waiting for merge
  • Draft
  • Trivial PR (nominal cosmetic/typo/whitespace changes)

Semantic Versioning

Please delete options that are not relevant. Ensure same has been covered in the commit message as well.

  • This is a fix change

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

This is a descope change that removes a file not in use.

Checklist:

  • My commit message mentions fix, feat, BREAKING CHANGE accordingly to increase the semantic versioning
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have checked my code/docs and corrected any misspellings

@haani-niyaz haani-niyaz requested a review from a user July 27, 2022 12:46
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM

@haani-niyaz haani-niyaz merged commit 14daf06 into main Jul 28, 2022
@github-actions
Copy link

🎉 This PR is included in version 0.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant