perf: Reduce memory usage by deduplicating type information #803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were storing the type information, 3 words wide, for each memo in each slot, while it is always constant wrt. the ingredient (different slots of the same ingredients will always have the same memos in the same order). This introduces some more unsafety, and the result wasn't as fast so I also had to use some lock-free structures, but the result is worth it: this shaves off 230mb from rust-analyzer with new Salsa.
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #803 will degrade performances by 6.69%Comparing Summary
Benchmarks breakdown
|
Veykril
force-pushed
the
veykril/push-ukowpnqompwy
branch
from
0fdb778 to
13a448e
Compare
Veykril
force-pushed
the
veykril/push-ukowpnqompwy
branch
from
13a448e to
ea12b6e
Compare
|
Given that this has the same performance and less unsafe code, let's close #649 and merge this. |
|
I can push my branch to yours if you want to retain the PR authorship |
I don't care. |
Veykril
changed the title
|
I'll go ahead and merge this given most of the work was by Chayim which I have reviewed. Perf is within noise and the memory savings are real. We'd like to upgrade our salsa today where having this in it would be pretty nice. |
Veykril
changed the title
This was referenced Apr 22, 2025
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.