Fix memo table growth condition #850
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for salsa-rs canceled.
|
ibraheemdev
force-pushed
the
memo-table-race
branch
from
7ba49ae to
86f2607
Compare
ibraheemdev
force-pushed
the
memo-table-race
branch
from
86f2607 to
ecb53cb
Compare
CodSpeed Performance ReportMerging #850 will not alter performanceComparing Summary
|
Merged
sharkdp
added a commit
to astral-sh/ruff
that referenced
this pull request
May 8, 2025
## Summary * Update salsa to pull in salsa-rs/salsa#850. * Some refactoring of salsa event callbacks in various `Db`'s due to salsa-rs/salsa#849 closes astral-sh/ty#108 ## Test Plan Ran `cargo run --bin ty -- -vvv` on a test file to make sure that salsa Events are still logged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
additional_lencalculation assumes thatmemos.len() <= memo_ingredient_index, which is not true in light of concurrent inserts. We're seeing spurious overflow panics because of this. It looks like this was changed in #803.