Skip to content

Refactor in favor to use primitiveOrStruct. #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
May 3, 2023
Merged

Refactor in favor to use primitiveOrStruct. #159

merged 21 commits into from
May 3, 2023

Conversation

ribeiromiranda
Copy link
Contributor

Refactor in favor to use primitiveOrStruct.

sonatype-lift[bot]
sonatype-lift bot reviewed Mar 10, 2023
View reviewed changes
sonatype-lift[bot]
sonatype-lift bot reviewed Mar 10, 2023
View reviewed changes
sonatype-lift[bot]
sonatype-lift bot reviewed Mar 10, 2023
View reviewed changes
@ribeiromiranda
Copy link
Contributor Author

Not found in the specification, what is the motivation for function unmarshalFile?

When a parameter can be a string or object, must always check if a string is a file path and try loading?

@ricardozanini
Copy link
Member

ricardozanini commented Mar 10, 2023 •
edited
Loading

@ribeiromiranda sometimes a reference can be an external file instead of a plain JSON object. In these cases, we need to load the file, process it and unmarshal it into a struct. So it's a string which is a URI.

@spolti
Copy link
Member

spolti commented Mar 13, 2023

@ribeiromiranda hi, can you please sign your commit and rebase the PR?
Thanks.

sonatype-lift[bot]
sonatype-lift bot reviewed Mar 15, 2023
View reviewed changes
@ricardozanini ricardozanini requested a review from spolti March 15, 2023 11:56
spolti
spolti reviewed Mar 15, 2023
View reviewed changes
@ribeiromiranda ribeiromiranda mentioned this pull request Mar 16, 2023
Merged
@spolti
Copy link
Member

spolti commented Mar 20, 2023

Hi @ribeiromiranda, can you please rebase?

spolti
spolti reviewed Mar 27, 2023
View reviewed changes
spolti
spolti reviewed Mar 27, 2023
View reviewed changes
@spolti
Copy link
Member

spolti commented Mar 27, 2023

@lsytj0413 hi, if you have time, do you mind reviewing this PR?
Thanks.

lsytj0413
lsytj0413 reviewed Mar 28, 2023
View reviewed changes
lsytj0413
lsytj0413 reviewed Mar 28, 2023
View reviewed changes
spolti
spolti reviewed Mar 28, 2023
View reviewed changes
spolti
spolti reviewed Mar 28, 2023
View reviewed changes
spolti
spolti reviewed Mar 28, 2023
View reviewed changes
spolti
spolti reviewed Mar 28, 2023
View reviewed changes
spolti
spolti reviewed Mar 28, 2023
View reviewed changes
spolti
spolti reviewed Mar 28, 2023
View reviewed changes
spolti
spolti reviewed Mar 28, 2023
View reviewed changes
spolti
spolti requested changes Mar 28, 2023
View reviewed changes
Copy link
Member

@spolti spolti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactoring :D
Few comments

lsytj0413
lsytj0413 reviewed Mar 31, 2023
View reviewed changes
@ribeiromiranda ribeiromiranda mentioned this pull request Apr 3, 2023
Closed
spolti
spolti reviewed Apr 6, 2023
View reviewed changes
spolti
spolti reviewed Apr 6, 2023
View reviewed changes
@ricardozanini
Copy link
Member

@ribeiromiranda anytime you feel it's safe to merge. I'm assuming you need a new patch version including this PR, right?

sonatype-lift[bot]
sonatype-lift bot reviewed May 3, 2023
View reviewed changes
sonatype-lift[bot]
sonatype-lift bot reviewed May 3, 2023
View reviewed changes
sonatype-lift[bot]
sonatype-lift bot reviewed May 3, 2023
View reviewed changes
sonatype-lift[bot]
sonatype-lift bot reviewed May 3, 2023
View reviewed changes
@ribeiromiranda
Copy link
Contributor Author

@ricardozanini Changed the getBytesFromFile to loadExternalResource adding more validation.

André R. de Miranda and others added 21 commits May 3, 2023 16:58
change unmarshalString to primitiveOrStruct
cedde1d 
Signed-off-by: André R. de Miranda <[email protected]>
Add unit test for DefaultCondition UnmarshalJSON
9e95171 
Signed-off-by: André R. de Miranda <[email protected]>
Improve switch case
31f9fc2 
Signed-off-by: André R. de Miranda <[email protected]>
Change unmarshall array/object/file and change error messages
506e15d 
Signed-off-by: André R. de Miranda <[email protected]>
Check response.Write error
3f91f01 
Signed-off-by: André R. de Miranda <[email protected]>
Move default values to the function ApplyDefault()
70ead09 
Signed-off-by: André R. de Miranda <[email protected]>
Change the go version to 1.20 on workflows
df3876e 
Signed-off-by: André R. de Miranda <[email protected]>
uri scheme empty the default is file://
efdadc5 
Signed-off-by: André R. de Miranda <[email protected]>
Change the golang version to 1.20.2. Fix lint
977a176 
Signed-off-by: André R. de Miranda <[email protected]>
Rebase from main branch
803c6fb 
Signed-off-by: André R. de Miranda <[email protected]>
Revision suggestions. Add a new interface for the types used in const…
7387405 
…, that aux the validation and error handling.

Signed-off-by: André R. de Miranda <[email protected]>
Refactor unmarshalObjectOrFile and unmarshalArrayOrFile
1d71c9d 
Signed-off-by: André R. de Miranda <[email protected]>
Revision suggestions. Rename interface Kinds to Kind
59135ac 
Signed-off-by: André R. de Miranda <[email protected]>
Accept external resource as object or array
33d4906 
Signed-off-by: André R. de Miranda <[email protected]>
Revision suggestions. Support golang 1.19 and external resource
c79f40d 
Signed-off-by: André R. de Miranda <[email protected]>
Revision suggestions
96b67bc 
Signed-off-by: André R. de Miranda <[email protected]>
Revision suggestions
4c5ed60 
Signed-off-by: André R. de Miranda <[email protected]>
Revision suggestions. Add more tests
ab70605 
Signed-off-by: André R. de Miranda <[email protected]>
@ribeiromiranda @spolti
Remove tag #nosec in model/util.go
72a3d07 
Co-authored-by: Filippe Spolti <[email protected]>
Signed-off-by: André R. de Miranda <[email protected]>
Rename AuthArray to Auths, and ErrorArray to Errors. Improve loadExte…
ce58327 
…rnalResource. Clean state json. Add state type validation oneofkind

Signed-off-by: André R. de Miranda <[email protected]>
Return json tags in state
0fdaceb 
Signed-off-by: André R. de Miranda <[email protected]>
@ricardozanini ricardozanini merged commit 2ee5933 into serverlessworkflow:main May 3, 2023
@ribeiromiranda ribeiromiranda deleted the refactor branch May 4, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsytj0413 lsytj0413 lsytj0413 left review comments

@sonatype-lift sonatype-lift[bot] sonatype-lift[bot] left review comments

@ricardozanini ricardozanini ricardozanini approved these changes

@spolti spolti spolti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ribeiromiranda @ricardozanini @spolti @lsytj0413