Validate the refs exists #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ricardozanini merged 15 commits into serverlessworkflow:main from galgotech:validate_exists

Jul 11, 2023

Contributor

ribeiromiranda commented Mar 16, 2023

Add validator with context to validate the refs (functions, events, retries, etc) exists

ribeiromiranda requested a review from ricardozanini as a code owner

March 16, 2023 18:18

github-actions bot added the source label

sonatype-lift bot reviewed

View reviewed changes

model/workflow_validator.go Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

model/workflow_validator.go Outdated Show resolved Hide resolved

Contributor Author

ribeiromiranda commented Mar 16, 2023

@ricardozanini To solve the unit test that PR (involve the default values of Function.Operation), I want to wait for PR #159.

sonatype-lift bot reviewed

View reviewed changes

model/workflow_validator.go Outdated Show resolved Hide resolved

Member

ricardozanini commented Apr 27, 2023

#159 should be merged soon.

Member

ricardozanini commented May 19, 2023

@ribeiromiranda any updates on this one?

Contributor Author

ribeiromiranda commented May 19, 2023

@ricardozanini Yes, but I didn't push it because there's a lot of unit testing to fix.

ribeiromiranda commented

View reviewed changes

model/workflow_validator.go Outdated Show resolved Hide resolved

spolti reviewed

View reviewed changes

model/workflow_validator.go Outdated Show resolved Hide resolved

ricardozanini reviewed

View reviewed changes

Member

ricardozanini left a comment

@ribeiromiranda, this is awesome work. Many many thanks for this. I imagine you're still working on it, right?

Apart from that, can you join the CNCF Slack, #serverless-workflow-sdk channel? I need to talk to you. Just send me a PM. :)

model/states_validator_test.go Outdated Show resolved Hide resolved

model/workflow_validator.go

+              }
+              func init() {
+              	// TODO: create states graph to complex check

Member

ricardozanini Jun 2, 2023

Can we have a follow-up issue to have it documented?

model/workflow_validator.go Outdated Show resolved Hide resolved

model/workflow_validator.go Outdated Show resolved Hide resolved

model/workflow_validator.go Outdated Show resolved Hide resolved

model/workflow_validator.go Outdated Show resolved Hide resolved

ricardozanini linked an issue

that may be closed by this pull request

cyclic import between validator and model packages #151

Closed

sonatype-lift bot reviewed

View reviewed changes

model/retry.go Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

util/unmarshal.go Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

util/unmarshal.go Outdated Show resolved Hide resolved

sonatype-lift bot reviewed

View reviewed changes

util/unmarshal.go Show resolved Hide resolved

Member

ricardozanini commented Jun 27, 2023

@ribeiromiranda are you still working on this, right? Please let me know when ready so we can have a final look + merge.

Contributor Author

ribeiromiranda commented Jun 27, 2023

@ribeiromiranda are you still working on this, right? Please let me know when ready so we can have a final look + merge.

@ricardozanini No more changes.

Member

ricardozanini commented Jun 27, 2023

@ribeiromiranda are you still working on this, right? Please let me know when ready so we can have a final look + merge.

@ricardozanini No more changes.

Can you take a look at the CI errors, then? So we can merge after it. cc @spolti

Contributor Author

ribeiromiranda commented Jun 29, 2023

@ricardozanini @spolti CI errors fixed.

ricardozanini approved these changes

View reviewed changes

Member

ricardozanini left a comment

Thank you!

validator/workflow.go Outdated Show resolved Hide resolved

spolti reviewed

View reviewed changes

model/workflow_validator.go Show resolved Hide resolved

spolti approved these changes

View reviewed changes

Member

spolti left a comment

Really nice :)

ricardozanini approved these changes

View reviewed changes

Member

ricardozanini commented Jun 30, 2023

Waiting for #178

André R. de Miranda added 4 commits

July 11, 2023 07:42


          Add validator with context to validate the refs (functions, events, r…

8816daf

…etries, etc) exists

Signed-off-by: André R. de Miranda <[email protected]>


          Valid errors exist and change unique_struct to unique

edcfc3e

Signed-off-by: André R. de Miranda <[email protected]>


          Fix lint

cce0955

Signed-off-by: André R. de Miranda <[email protected]>


          Add transition and compensation validations. Refactor state exists

f06a340

Signed-off-by: André R. de Miranda <[email protected]>

André R. de Miranda added 11 commits

July 11, 2023 07:42


          Json ignore field

6dcdc3e

Signed-off-by: André R. de Miranda <[email protected]>


          Fix tests

902b1c2

Signed-off-by: André R. de Miranda <[email protected]>


          Add validations: OnEvent.EventRefs, EventCondition.EventRef, and Func…

54f6fdb

…tionType

Signed-off-by: André R. de Miranda <[email protected]>


          Fix tests

b4b711f

Signed-off-by: André R. de Miranda <[email protected]>


          Replace oneof to oneofkind, and improve the error message

b0556b2

Signed-off-by: André R. de Miranda <[email protected]>


          Validation refactoring for each struct to have its test case. Revisio…

cc289bc

…n suggestions

Signed-off-by: André R. de Miranda <[email protected]>


          Add validation oneofkind validation auth struct

164a81f

Signed-off-by: André R. de Miranda <[email protected]>


          Add new tests and improve error description

c01b2eb

Signed-off-by: André R. de Miranda <[email protected]>


          Add new unit tests, refactor intstr validator, and add new validation…

c6ba01c

… description

Signed-off-by: André R. de Miranda <[email protected]>


          Remove reflection from validation

67477a0

Signed-off-by: André R. de Miranda <[email protected]>


          Remove commented code

d58baa1

Signed-off-by: André R. de Miranda <[email protected]>

Contributor Author

ribeiromiranda commented Jul 11, 2023

Waiting for #178

@ricardozanini Made the rebase with the main branch.

ricardozanini merged commit 4afc5f3 into serverlessworkflow:main

ribeiromiranda deleted the validate_exists branch

July 12, 2023 01:00

spolti mentioned this pull request

Add Inject State struct level validation tests #150

Closed

spolti mentioned this pull request

[KOGITO-9485] - Bump sdk-go to v2.2.4 apache/incubator-kie-kogito-serverless-operator#244

Merged

2 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet