ENH: linkcheck: also write all links to output.json #7103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tk0miya
requested changes
Feb 8, 2020
westurner
force-pushed
the
linkcheck_json_output
branch
from
5c818cb to
7a954ac
Compare
westurner
changed the title
|
Seems to build fine here with |
|
The output order is nondeterministic presumably due to variance in network latency. |
tk0miya
reviewed
Feb 9, 2020
westurner
force-pushed
the
linkcheck_json_output
branch
from
8cf080f to
8e29044
Compare
|
... The python: nightly job is returning this, which is probably not an error with this PR? $ if [ $IS_PYTHON = true ]; then pip install -U tox codecov; fi
Traceback (most recent call last):
File "/home/travis/virtualenv/python3.9-dev/bin/pip", line 6, in <module>
from pip._internal.cli.main import main
ModuleNotFoundError: No module named 'pip' |
|
In addition, please merge master branch to this branch to fix the CI error. |
westurner
force-pushed
the
linkcheck_json_output
branch
4 times, most recently
from
e14970b to
88e312c
Compare
|
I'm tempted to start an http.server as a |
* TST: linkcheck: make tests more flexible * CLN: linkcheck: flake8, mypy * REF: linkcheck: docpath->filename, write_jsonline->write_linkstat * REF: linkcheck: remove redundant call to doc2path * TST: linkcheck: show JSON obj structure in test * REF: linkcheck: remove docname from JSON obj because it's redundant (use path2doc(filename) if necessary) * TST: linkcheck: don't test row[info] output (see comments for examples)
westurner
force-pushed
the
linkcheck_json_output
branch
from
88e312c to
fd94270
Compare
|
This is otherwise rebased onto latest master with: git checkout master
git pull upstream master
git checkout linkcheck_json_output
git rebase -i masterAnd squashed |
tk0miya
approved these changes
Mar 1, 2020
|
Merged. Thank you for your work! |
tk0miya
added a commit
that referenced
this pull request
Mar 1, 2020
|
Thanks!
…On Sun, Mar 1, 2020, 3:43 AM Takeshi KOMIYA ***@***.***> wrote:
Merged. Thank you for your work!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7103?email_source=notifications&email_token=AAAMNS7TQHJ3FI4KPCRHBH3RFIN2BA5CNFSM4KRKCKN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENMY2HI#issuecomment-593071389>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMNSZUJSLQ4R32TVLHPHTRFIN2BANCNFSM4KRKCKNQ>
.
|
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject: Write linkcheck output to JSON lines in
_build/linkcheck/output.jsonThis is off 1.8.5. If it would be considered, I'd be glad to rebase it onto master.
(edit)
This is now off master.
Feature or Bugfix
Purpose
_build/linkcheck/output.json(in order to eventually create a tool to prompt to fix links)
Detail
Relates