BLD: tox.ini: flake8: add whitelist_externals for latest tox instead of adding dep, pass posargs through #7129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of adding dep, pass posargs through
westurner
changed the title
|
... The python: nightly job is returning this, which is probably not an error with this PR? $ if [ $IS_PYTHON = true ]; then pip install -U tox codecov; fi
Traceback (most recent call last):
File "/home/travis/virtualenv/python3.9-dev/bin/pip", line 6, in <module>
from pip._internal.cli.main import main
ModuleNotFoundError: No module named 'pip' |
Yes, it comes from nightly image itself. For more details, see #7132. |
|
Merged. Thank you for your contribution! |
|
Thanks for the review!
…On Tue, Feb 11, 2020, 10:50 AM Takeshi KOMIYA ***@***.***> wrote:
Merged. Thank you for your contribution!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7129?email_source=notifications&email_token=AAAMNS2AH3KZZFFM5RZG7WLRCLCLXA5CNFSM4KSW2HTKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELM5UCA#issuecomment-584702472>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMNS4P5MEA3S7U4IBQUUDRCLCLXANCNFSM4KSW2HTA>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BLD: tox.ini: flake8: add whitelist_externals for latest tox instead of adding dep, pass posargs through
Subject: Update tox.ini for latest tox version and pass posargs through
Feature or Bugfix
Purpose
Detail
Passing posargs through makes it possible to check specific files:
Specifying
whitelist_externalseliminates an error message without requiring (re)install of flake8 for every run as adding todepswould result in.https://tox.readthedocs.io/en/latest/config.html#conf-whitelist_externals
Relates