Skip to content

ModuleEntryInterceptor sitting before the async invocation interceptor causes traces to place spans in the wrong place #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
odrotbohm opened this issue May 21, 2024 · 0 comments
Assignees
Labels
in: observability Observability support type: bug Something isn't working
Milestone

Comments

@odrotbohm
Copy link
Member

ModuleTracingBeanPostProcessor always registers the interceptor as first in the advisor chain. If the AsyncAnnotationAdvisor is already present, this will cause close to empty spans for async event listeners as the span starts before the async dispatch and immediately ends.

@odrotbohm odrotbohm added in: observability Observability support type: bug Something isn't working labels May 21, 2024
@odrotbohm odrotbohm added this to the 1.2 milestone May 21, 2024
@odrotbohm odrotbohm self-assigned this May 21, 2024
odrotbohm added a commit that referenced this issue May 21, 2024
…he AsyncAnnotationAdvisor.

To properly create spans for the actual method invocation, not the async dispatch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: observability Observability support type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant